Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 849283003: PPAPI generator: Ignore more date-only changes (Closed)

Created:
5 years, 11 months ago by dmichael (off chromium)
Modified:
5 years, 11 months ago
Reviewers:
bbudge
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PPAPI generator: Ignore more date-only changes Previously, the generator could only ignore changes in the: // From FILENAME.idl modified DAY MON DATE TIME YEAR. line if it was not wrapped or wrapped in a specific place. (Note this line would otherwise change every time you generate). This CL makes it a little better, in that it will ignore timestamp changes regardless of where the "modified" output is wrapped. Otherwise, the generator wants to update a few thunk files because it's now 2015. See: https://codereview.chromium.org/849473003/ for context. BUG= R=bbudge@chromium.org Committed: https://crrev.com/cd4ea7fe9e50ba0ee0ac3f08aeb0bb21653ee00b Cr-Commit-Position: refs/heads/master@{#311767}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M ppapi/generators/idl_outfile.py View 2 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
dmichael (off chromium)
This seems to do the right thing locally.
5 years, 11 months ago (2015-01-15 21:28:56 UTC) #1
bbudge
LGTM Thanks!
5 years, 11 months ago (2015-01-15 21:36:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/849283003/1
5 years, 11 months ago (2015-01-15 21:39:45 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-15 23:33:06 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-15 23:34:14 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cd4ea7fe9e50ba0ee0ac3f08aeb0bb21653ee00b
Cr-Commit-Position: refs/heads/master@{#311767}

Powered by Google App Engine
This is Rietveld 408576698