Issue 849243002: Why are we afraid of saveLayer() bounds?

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 849243002: Why are we afraid of saveLayer() bounds? (Closed)

Created:
5 years, 11 months ago by mtklein_C

Modified:
5 years, 11 months ago

Reviewers:
mtklein, robertphillips

CC:
reviews_skia.org, Kimmo Kinnunen

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Why are we afraid of saveLayer() bounds? They're only hints. We can ignore them in this optimization. My only hesitation is that this pattern doesn't seem to happen in our .skps. BUG=skia: Committed: https://skia.googlesource.com/skia/+/0c278972d06882f21dda07e17d6e7457f590ea69

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -14 lines)			Patch
	M	src/core/SkRecordOpts.cpp	View		1 chunk	+2 lines, -7 lines	0 comments	Download
	M	tests/RecordOptsTest.cpp	View		1 chunk	+5 lines, -7 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/849243002/1

5 years, 11 months ago (2015-01-15 15:33:27 UTC) #4

commit-bot: I haz the power

Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...

5 years, 11 months ago (2015-01-15 15:33:28 UTC) #5

commit-bot: I haz the power

5 years, 11 months ago (2015-01-15 16:08:13 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/0c278972d06882f21dda07e17d6e7457f590ea69