Issue 8492014: Fix for http://code.google.com/p/dart/issues/detail?id=361 (Open Declaration does not work for so...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8492014: Fix for http://code.google.com/p/dart/issues/detail?id=361 (Open Declaration does not work for so... (Closed)

Created:
9 years, 1 month ago by Brian Wilkerson

Modified:
9 years, 1 month ago

Reviewers:
danrubel

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Description

Fix for http://code.google.com/p/dart/issues/detail?id=361 (Open Declaration does not work for source directives containing paths) Committed: https://code.google.com/p/dart/source/detail?r=1266

Patch Set 1 #

Total comments: 2

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -1 line)			Patch
	M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/ast/DartElementLocator.java	View		3 chunks	+25 lines, -1 line	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

danrubel

lgtm http://codereview.chromium.org/8492014/diff/1/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/ast/DartElementLocator.java File editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/ast/DartElementLocator.java (right): http://codereview.chromium.org/8492014/diff/1/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/ast/DartElementLocator.java#newcode523 editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/ast/DartElementLocator.java:523: } Do we need the code above? Will ...

9 years, 1 month ago (2011-11-07 19:30:21 UTC) #2

Brian Wilkerson

9 years, 1 month ago (2011-11-07 19:40:33 UTC) #3

http://codereview.chromium.org/8492014/diff/1/editor/tools/plugins/com.google...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/ast/DartElementLocator.java
(right):

http://codereview.chromium.org/8492014/diff/1/editor/tools/plugins/com.google...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/ast/DartElementLocator.java:523:
}
> Do we need the code above? Will the code below always work?

I don't think so. I removed it.

Expand Messages | Collapse Messages