Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2973)

Issue 849133002: convert pdf design document to markdown (Closed)

Created:
5 years, 11 months ago by hal.canary
Modified:
5 years, 11 months ago
Reviewers:
jcgregorio
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

convert pdf design document to markdown Committed: https://skia.googlesource.com/skia/+/211fcc6831e2339c12461fd600a28975210cb4d8

Patch Set 1 : Another Patch Set #

Total comments: 4

Patch Set 2 : Another Patch Set #

Patch Set 3 : Another Patch Set #

Unified diffs Side-by-side diffs Delta from patch set Stats (+628 lines, -0 lines) Patch
A site/dev/design/index.md View 1 1 chunk +4 lines, -0 lines 0 comments Download
A site/dev/design/pdftheory.md View 1 1 chunk +595 lines, -0 lines 0 comments Download
A site/user/sample/pdf.md View 1 2 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 26 (20 generated)
hal.canary
ptal
5 years, 11 months ago (2015-01-14 21:08:22 UTC) #18
jcgregorio
https://codereview.chromium.org/849133002/diff/310001/site/dev/design/index.md File site/dev/design/index.md (right): https://codereview.chromium.org/849133002/diff/310001/site/dev/design/index.md#newcode2 site/dev/design/index.md:2: ======================= Make the underline match the header length. https://codereview.chromium.org/849133002/diff/310001/site/dev/design/pdftheory.md ...
5 years, 11 months ago (2015-01-14 21:19:12 UTC) #19
hal.canary
https://codereview.chromium.org/849133002/diff/310001/site/dev/design/index.md File site/dev/design/index.md (right): https://codereview.chromium.org/849133002/diff/310001/site/dev/design/index.md#newcode2 site/dev/design/index.md:2: ======================= On 2015/01/14 21:19:11, jcgregorio wrote: > Make the ...
5 years, 11 months ago (2015-01-20 18:02:05 UTC) #22
jcgregorio
lgtm
5 years, 11 months ago (2015-01-20 18:30:44 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/849133002/390001
5 years, 11 months ago (2015-01-20 18:31:51 UTC) #25
commit-bot: I haz the power
5 years, 11 months ago (2015-01-20 18:39:09 UTC) #26
Message was sent while issue was closed.
Committed patchset #3 (id:390001) as
https://skia.googlesource.com/skia/+/211fcc6831e2339c12461fd600a28975210cb4d8

Powered by Google App Engine
This is Rietveld 408576698