Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 849113002: Ensure unittests are built when building all (Closed)

Created:
5 years, 11 months ago by jam
Modified:
5 years, 11 months ago
Reviewers:
Tom Sepez, scottmg
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/all.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
jam
5 years, 11 months ago (2015-01-14 19:15:06 UTC) #2
jam
->scottmg
5 years, 11 months ago (2015-01-14 21:28:58 UTC) #4
jam
5 years, 11 months ago (2015-01-14 21:29:03 UTC) #5
scottmg
lgtm
5 years, 11 months ago (2015-01-14 21:31:20 UTC) #6
jam
Committed patchset #1 (id:1) manually as c53eaa732ff61561ad237bc9c125db1ed2e42780 (presubmit successful).
5 years, 11 months ago (2015-01-14 21:34:27 UTC) #7
Tom Sepez
LGTM. Sorry about the delay. Did you merge this to XFA branch, or should I ...
5 years, 11 months ago (2015-01-15 17:53:47 UTC) #9
Tom Sepez
5 years, 11 months ago (2015-01-15 20:11:18 UTC) #10
Message was sent while issue was closed.
NM. I've put together the merge at https://codereview.chromium.org/841183003/
and will land it presently.

Powered by Google App Engine
This is Rietveld 408576698