Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 849103007: arm (Closed)

Created:
5 years, 11 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 11 months ago
Reviewers:
dcarney
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

arm

Patch Set 1 #

Total comments: 3

Patch Set 2 : updates #

Patch Set 3 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+449 lines, -210 lines) Patch
M include/v8.h View 4 chunks +4 lines, -4 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 1 2 6 chunks +62 lines, -30 lines 0 comments Download
M src/arm/interface-descriptors-arm.cc View 1 chunk +25 lines, -0 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 2 4 chunks +16 lines, -10 lines 0 comments Download
M src/code-stubs.h View 1 3 chunks +25 lines, -12 lines 0 comments Download
M src/hydrogen.cc View 3 chunks +28 lines, -23 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 7 chunks +70 lines, -35 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 2 chunks +15 lines, -7 lines 0 comments Download
M src/ic/arm/handler-compiler-arm.cc View 3 chunks +8 lines, -9 lines 0 comments Download
M src/ic/handler-compiler.h View 1 chunk +5 lines, -5 lines 0 comments Download
M src/ic/handler-compiler.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M src/ic/ia32/handler-compiler-ia32.cc View 2 chunks +7 lines, -8 lines 0 comments Download
M src/ic/x64/handler-compiler-x64.cc View 2 chunks +7 lines, -8 lines 0 comments Download
M src/interface-descriptors.h View 2 chunks +8 lines, -1 line 0 comments Download
M src/x64/code-stubs-x64.cc View 7 chunks +75 lines, -36 lines 0 comments Download
M src/x64/interface-descriptors-x64.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 2 chunks +15 lines, -7 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +24 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
dcarney
5 years, 11 months ago (2015-01-15 10:11:37 UTC) #2 
https://codereview.chromium.org/849103007/diff/1/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):

https://codereview.chromium.org/849103007/diff/1/src/arm/code-stubs-arm.cc#ne...
src/arm/code-stubs-arm.cc:4699: __ add(scratch, scratch, Operand(length_value,
LSL, 2));
2 should be kPointerSizeLog2

https://codereview.chromium.org/849103007/diff/1/src/arm/code-stubs-arm.cc#ne...
src/arm/code-stubs-arm.cc:4700: __ add(scratch, scratch,
Operand((FCA::kArgsLength - 1) * kPointerSize));
should be able to do this with fused add multiply, no?

https://codereview.chromium.org/849103007/diff/1/src/arm/code-stubs-arm.cc#ne...
src/arm/code-stubs-arm.cc:4714: __ mov(ip, Operand(length_value, LSL, 3));
3 should be kPointerSizeLog2 + 1 to make it clear where it comes from

Powered by Google App Engine
This is Rietveld 408576698