Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: tools/json_schema_compiler/preview.py

Issue 849103005: Cleanup most pylint errors in json_schema_compiler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/json_schema_compiler/preview.py
diff --git a/tools/json_schema_compiler/preview.py b/tools/json_schema_compiler/preview.py
index 050af9637efbe9ca7eb5d5d6c5819e23c5a4162e..e423598cc272469333e5412e698ad2e6c095e374 100755
--- a/tools/json_schema_compiler/preview.py
+++ b/tools/json_schema_compiler/preview.py
@@ -201,7 +201,6 @@ updateEverything();
namespace)
# Generate code
- cpp_namespace = 'generated_api_schemas'
if file_ext == '.h':
cpp_code = (h_generator.HGenerator(type_generator)
.Generate(namespace).Render())
@@ -286,7 +285,7 @@ updateEverything();
# Each file under path/
for filename in sorted(os.listdir(path)):
full_path = os.path.join(path, filename)
- (file_root, file_ext) = os.path.splitext(full_path)
+ file_ext = os.path.splitext(full_path)[1]
not at google - send to devlin 2015/01/14 22:44:41 ditto
if os.path.isdir(full_path) and not full_path.endswith('.xcodeproj'):
html.Append('<li><a href="/%s/">%s/</a>' % (full_path, filename))
elif file_ext in ['.json', '.idl']:

Powered by Google App Engine
This is Rietveld 408576698