Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: include/core/SkImageDecoder.h

Issue 849103004: Make SkStream *not* ref counted. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Rebase, just in case. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gm/dftext.cpp ('k') | include/core/SkPicture.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/core/SkImageDecoder.h
diff --git a/include/core/SkImageDecoder.h b/include/core/SkImageDecoder.h
index a0bcd33c7b9e322255be3da72365cb2b5df38452..4dfd3c24e091e67067fa04c1ace149223bf5e07f 100644
--- a/include/core/SkImageDecoder.h
+++ b/include/core/SkImageDecoder.h
@@ -243,6 +243,8 @@ public:
* The built index will be saved in the decoder, and the image size will
* be returned in width and height.
*
+ * Takes ownership of the SkStreamRewindable, on success or failure.
+ *
* Return true for success or false on failure.
*/
bool buildTileIndex(SkStreamRewindable*, int *width, int *height);
@@ -307,11 +309,9 @@ protected:
// must be overridden in subclasses. This guy is called by decode(...)
virtual Result onDecode(SkStream*, SkBitmap* bitmap, Mode) = 0;
- // If the decoder wants to support tiled based decoding,
- // this method must be overridden. This guy is called by buildTileIndex(...)
- virtual bool onBuildTileIndex(SkStreamRewindable*, int* /*width*/, int* /*height*/) {
- return false;
- }
+ // If the decoder wants to support tiled based decoding, this method must be overridden.
+ // This is called by buildTileIndex(...)
+ virtual bool onBuildTileIndex(SkStreamRewindable*, int* /*width*/, int* /*height*/);
// If the decoder wants to support tiled based decoding,
// this method must be overridden. This guy is called by decodeRegion(...)
« no previous file with comments | « gm/dftext.cpp ('k') | include/core/SkPicture.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698