Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1365)

Unified Diff: experimental/PdfViewer/inc/SkPdfRenderer.h

Issue 849103004: Make SkStream *not* ref counted. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Rebase, just in case. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dm/DMSrcSink.cpp ('k') | experimental/PdfViewer/pdfparser/native/SkPdfNativeDoc.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: experimental/PdfViewer/inc/SkPdfRenderer.h
diff --git a/experimental/PdfViewer/inc/SkPdfRenderer.h b/experimental/PdfViewer/inc/SkPdfRenderer.h
index 9fc1ff7c6b3b79f2bdb84875899bf719130d3606..9882a612cfdecf072048e814d7a185947e7242fb 100644
--- a/experimental/PdfViewer/inc/SkPdfRenderer.h
+++ b/experimental/PdfViewer/inc/SkPdfRenderer.h
@@ -35,6 +35,7 @@ public:
// TODO(edisonn): replace it with a SkSmartStream which would know to to efficiently
// deal with a HTTP stream.
// FIXME: Untested.
+ // Does not affect ownership of SkStream.
static SkPdfRenderer* CreateFromStream(SkStream*);
// Create a new renderer from a file.
static SkPdfRenderer* CreateFromFile(const char* filename);
@@ -64,6 +65,7 @@ private:
void reportPdfRenderStats();
// Renders a page of a pdf in a bitmap.
+// Does not affect ownership of stream.
bool SkPDFNativeRenderToBitmap(SkStream* stream,
SkBitmap* output,
int page = 0,
« no previous file with comments | « dm/DMSrcSink.cpp ('k') | experimental/PdfViewer/pdfparser/native/SkPdfNativeDoc.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698