src/images/SkMovie.cpp - Issue 849103004: Make SkStream *not* ref counted.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/images/SkMovie.cpp

Issue 849103004: Make SkStream *not* ref counted. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Delete streams in onCreateFromStream failures. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/images/SkMovie.cpp

diff --git a/src/images/SkMovie.cpp b/src/images/SkMovie.cpp

index 9a2a71cd57c599cf156482c69a372cac6cd20bef..2a1339f36e558798e46e907bc2d8c2f4e24709fd 100644

--- a/src/images/SkMovie.cpp

+++ b/src/images/SkMovie.cpp

@@ -90,6 +90,6 @@ SkMovie* SkMovie::DecodeMemory(const void* data, size_t length) {

}

SkMovie* SkMovie::DecodeFile(const char path[]) {

- SkAutoTUnref<SkStreamRewindable> stream(SkStream::NewFromFile(path));

+ SkAutoTDelete<SkStreamRewindable> stream(SkStream::NewFromFile(path));

return stream.get() ? SkMovie::DecodeStream(stream) : NULL;

}