src/fonts/SkFontMgr_fontconfig.cpp - Issue 849103004: Make SkStream *not* ref counted.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/fonts/SkFontMgr_fontconfig.cpp

Issue 849103004: Make SkStream *not* ref counted. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Rebase Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/fonts/SkFontMgr_fontconfig.cpp

diff --git a/src/fonts/SkFontMgr_fontconfig.cpp b/src/fonts/SkFontMgr_fontconfig.cpp

index a3989fca75cdfc39c260c75f4ddf5d981f10feb3..3e71ab0becc96faa53a1e0a136b372f6ef723671 100644

--- a/src/fonts/SkFontMgr_fontconfig.cpp

+++ b/src/fonts/SkFontMgr_fontconfig.cpp

@@ -316,7 +316,7 @@ protected:

}

SkTypeface* onCreateFromFile(const char path[], int ttcIndex) const SK_OVERRIDE {

- SkAutoTUnref<SkStream> stream(SkStream::NewFromFile(path));

+ SkAutoTDelete<SkStream> stream(SkStream::NewFromFile(path));

bungeman-skia 2015/01/20 21:41:48 I don't think this guy should be deleting the stre

scroggo 2015/01/20 22:19:09 Done.

return stream.get() ? this->createFromStream(stream, ttcIndex) : NULL;

}