tools/dump_record.cpp - Issue 849103004: Make SkStream *not* ref counted.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dump_record.cpp

Issue 849103004: Make SkStream *not* ref counted. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Treat SkFontMgr::createFromStream as taking ownership of the stream (is this correct?) Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/dump_record.cpp

diff --git a/tools/dump_record.cpp b/tools/dump_record.cpp

index fc2e1026233bfbc49867d518a2d3623ae4ced6db..885046a1d1871076794880cf15285bb1947743fe 100644

--- a/tools/dump_record.cpp

+++ b/tools/dump_record.cpp

@@ -46,7 +46,7 @@ int tool_main(int argc, char** argv) {

continue;

}

- SkAutoTUnref<SkStream> stream(SkStream::NewFromFile(FLAGS_skps[i]));

+ SkAutoTDelete<SkStream> stream(SkStream::NewFromFile(FLAGS_skps[i]));

if (!stream) {

SkDebugf("Could not read %s.\n", FLAGS_skps[i]);

exit(1);