tests/FontHostStreamTest.cpp - Issue 849103004: Make SkStream *not* ref counted.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/FontHostStreamTest.cpp

Issue 849103004: Make SkStream *not* ref counted. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Treat SkFontMgr::createFromStream as taking ownership of the stream (is this correct?) Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/FontHostStreamTest.cpp

diff --git a/tests/FontHostStreamTest.cpp b/tests/FontHostStreamTest.cpp

index 18c74605bfffc8fb220925642648d15c69d2ef2b..affda98cf60fd4c611776462565194d6ca45e13d 100644

--- a/tests/FontHostStreamTest.cpp

+++ b/tests/FontHostStreamTest.cpp

@@ -96,8 +96,8 @@ DEF_TEST(FontHostStream, reporter) {

}

int ttcIndex;

- SkAutoTUnref<SkStream> fontData(origTypeface->openStream(&ttcIndex));

- SkTypeface* streamTypeface = SkTypeface::CreateFromStream(fontData);

+ SkAutoTDelete<SkStream> fontData(origTypeface->openStream(&ttcIndex));

+ SkTypeface* streamTypeface = SkTypeface::CreateFromStream(fontData.detach());

SkFontDescriptor desc;

bool isLocalStream = false;