src/utils/win/SkDWriteFontFileStream.h - Issue 849103004: Make SkStream *not* ref counted.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/utils/win/SkDWriteFontFileStream.h

Issue 849103004: Make SkStream *not* ref counted. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Treat SkFontMgr::createFromStream as taking ownership of the stream (is this correct?) Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/utils/win/SkDWriteFontFileStream.h

diff --git a/src/utils/win/SkDWriteFontFileStream.h b/src/utils/win/SkDWriteFontFileStream.h

index 1800e2fecadcaf80eac6b28e0197c98c22b8101a..a7e41254fbd3770da6b8cfc6ea91ee02931cd3fe 100644

--- a/src/utils/win/SkDWriteFontFileStream.h

+++ b/src/utils/win/SkDWriteFontFileStream.h

@@ -71,7 +71,7 @@ private:

virtual ~SkDWriteFontFileStreamWrapper() { }

ULONG fRefCount;

- SkAutoTUnref<SkStream> fStream;

+ SkAutoTDelete<SkStream> fStream;

SkMutex fStreamMutex;

};

#endif