src/gpu/gl/GrGLPathRendering.cpp - Issue 849103004: Make SkStream *not* ref counted.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/gl/GrGLPathRendering.cpp

Issue 849103004: Make SkStream *not* ref counted. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Treat SkFontMgr::createFromStream as taking ownership of the stream (is this correct?) Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/gl/GrGLPathRendering.cpp

diff --git a/src/gpu/gl/GrGLPathRendering.cpp b/src/gpu/gl/GrGLPathRendering.cpp

index 93f892d3b36c8d31701a27d88c8f1ab006a1164e..5c0d1c72f15276372f030980ee5e386ca0d5d8ba 100644

--- a/src/gpu/gl/GrGLPathRendering.cpp

+++ b/src/gpu/gl/GrGLPathRendering.cpp

@@ -124,7 +124,7 @@ GrPathRange* GrGLPathRendering::createGlyphs(const SkTypeface* typeface,

}

int faceIndex;

- SkAutoTUnref<SkStream> fontStream(typeface->openStream(&faceIndex));

+ SkAutoTDelete<SkStream> fontStream(typeface->openStream(&faceIndex));

const size_t fontDataLength = fontStream->getLength();

if (0 == fontDataLength) {