Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: src/pdf/SkPDFStream.cpp

Issue 849103004: Make SkStream *not* ref counted. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Rebase, just in case. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/pdf/SkPDFStream.h ('k') | src/ports/SkFontConfigTypeface.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 1
2 /* 2 /*
3 * Copyright 2010 Google Inc. 3 * Copyright 2010 Google Inc.
4 * 4 *
5 * Use of this source code is governed by a BSD-style license that can be 5 * Use of this source code is governed by a BSD-style license that can be
6 * found in the LICENSE file. 6 * found in the LICENSE file.
7 */ 7 */
8 8
9 9
10 #include "SkData.h" 10 #include "SkData.h"
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 this->INHERITED::emitObject(stream, catalog); 54 this->INHERITED::emitObject(stream, catalog);
55 stream->writeText(" stream\n"); 55 stream->writeText(" stream\n");
56 stream->writeStream(fDataStream.get(), fDataStream->getLength()); 56 stream->writeStream(fDataStream.get(), fDataStream->getLength());
57 SkAssertResult(fDataStream->rewind()); 57 SkAssertResult(fDataStream->rewind());
58 stream->writeText("\nendstream"); 58 stream->writeText("\nendstream");
59 } 59 }
60 60
61 SkPDFStream::SkPDFStream() : fState(kUnused_State) {} 61 SkPDFStream::SkPDFStream() : fState(kUnused_State) {}
62 62
63 void SkPDFStream::setData(SkData* data) { 63 void SkPDFStream::setData(SkData* data) {
64 fMemoryStream.setData(data); 64 // FIXME: Don't swap if the data is the same.
65 if (&fMemoryStream != fDataStream.get()) { 65 fDataStream.reset(SkNEW_ARGS(SkMemoryStream, (data)));
66 fDataStream.reset(SkRef(&fMemoryStream));
67 }
68 } 66 }
69 67
70 void SkPDFStream::setData(SkStream* stream) { 68 void SkPDFStream::setData(SkStream* stream) {
71 // Code assumes that the stream starts at the beginning and is rewindable. 69 // Code assumes that the stream starts at the beginning and is rewindable.
72 if (&fMemoryStream == fDataStream.get()) {
73 SkASSERT(&fMemoryStream != stream);
74 fMemoryStream.setData(NULL);
75 }
76 SkASSERT(0 == fMemoryStream.getLength());
77 if (stream) { 70 if (stream) {
78 // SkStreamRewindableFromSkStream will try stream->duplicate(). 71 // SkStreamRewindableFromSkStream will try stream->duplicate().
79 fDataStream.reset(SkStreamRewindableFromSkStream(stream)); 72 fDataStream.reset(SkStreamRewindableFromSkStream(stream));
80 SkASSERT(fDataStream.get()); 73 SkASSERT(fDataStream.get());
81 } else { 74 } else {
82 fDataStream.reset(SkRef(&fMemoryStream)); 75 // Use an empty memory stream.
76 fDataStream.reset(SkNEW(SkMemoryStream));
83 } 77 }
84 } 78 }
85 79
86 size_t SkPDFStream::dataSize() const { 80 size_t SkPDFStream::dataSize() const {
87 SkASSERT(fDataStream->hasLength()); 81 SkASSERT(fDataStream->hasLength());
88 return fDataStream->getLength(); 82 return fDataStream->getLength();
89 } 83 }
90 84
91 bool SkPDFStream::populate(SkPDFCatalog* catalog) { 85 bool SkPDFStream::populate(SkPDFCatalog* catalog) {
92 if (fState == kUnused_State) { 86 if (fState == kUnused_State) {
93 if (!skip_compression(catalog) && SkFlate::HaveFlate()) { 87 if (!skip_compression(catalog) && SkFlate::HaveFlate()) {
94 SkDynamicMemoryWStream compressedData; 88 SkDynamicMemoryWStream compressedData;
95 89
96 SkAssertResult( 90 SkAssertResult(
97 SkFlate::Deflate(fDataStream.get(), &compressedData)); 91 SkFlate::Deflate(fDataStream.get(), &compressedData));
98 SkAssertResult(fDataStream->rewind()); 92 SkAssertResult(fDataStream->rewind());
99 if (compressedData.getOffset() < this->dataSize()) { 93 if (compressedData.getOffset() < this->dataSize()) {
100 SkAutoTUnref<SkStream> compressed( 94 SkAutoTDelete<SkStream> compressed(
101 compressedData.detachAsStream()); 95 compressedData.detachAsStream());
102 this->setData(compressed.get()); 96 this->setData(compressed.get());
103 insertName("Filter", "FlateDecode"); 97 insertName("Filter", "FlateDecode");
104 } 98 }
105 fState = kCompressed_State; 99 fState = kCompressed_State;
106 } else { 100 } else {
107 fState = kNoCompression_State; 101 fState = kNoCompression_State;
108 } 102 }
109 insertInt("Length", this->dataSize()); 103 insertInt("Length", this->dataSize());
110 } else if (fState == kNoCompression_State && !skip_compression(catalog) && 104 } else if (fState == kNoCompression_State && !skip_compression(catalog) &&
111 SkFlate::HaveFlate()) { 105 SkFlate::HaveFlate()) {
112 if (!fSubstitute.get()) { 106 if (!fSubstitute.get()) {
113 fSubstitute.reset(new SkPDFStream(*this)); 107 fSubstitute.reset(new SkPDFStream(*this));
114 catalog->setSubstitute(this, fSubstitute.get()); 108 catalog->setSubstitute(this, fSubstitute.get());
115 } 109 }
116 return false; 110 return false;
117 } 111 }
118 return true; 112 return true;
119 } 113 }
OLDNEW
« no previous file with comments | « src/pdf/SkPDFStream.h ('k') | src/ports/SkFontConfigTypeface.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698