Make SkStream *not* ref counted.

src/fonts/SkFontMgr_fontconfig.cpp

 /*
  * Copyright 2013 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkFontMgr.h"
 #include "SkFontStyle.h"
 #include "SkFontConfigInterface.h"
@@ skipping 290 matching lines @@
             return NULL;
         }
         if (length >= 1024 * 1024 * 1024) {
             return NULL;  // don't accept too large fonts (>= 1GB) for safety.
         }
 
         // TODO should the caller give us the style or should we get it from freetype?
         SkFontStyle style;
         bool isFixedWidth = false;
         if (!fScanner.scanFont(stream, 0, NULL, &style, &isFixedWidth)) {
             return NULL;

[bungeman-skia, 2015/01/20 21:41:48]

Looks like we need to delete the stream here?

[scroggo, 2015/01/20 22:19:09]

Done with SkAutoTDelete.

         }
 
         SkTypeface* face = FontConfigTypeface::Create(style, isFixedWidth, stream);
         return face;
     }
 
     SkTypeface* onCreateFromFile(const char path[], int ttcIndex) const SK_OVERRIDE {
-        SkAutoTUnref<SkStream> stream(SkStream::NewFromFile(path));
+        SkAutoTDelete<SkStream> stream(SkStream::NewFromFile(path));

[bungeman-skia, 2015/01/20 21:41:48]

I don't think this guy should be deleting the stream, as it should be passing
ownership to createFromStream.

[scroggo, 2015/01/20 22:19:09]

Done.

         return stream.get() ? this->createFromStream(stream, ttcIndex) : NULL;
     }
 
     virtual SkTypeface* onLegacyCreateTypeface(const char familyName[],
                                                unsigned styleBits) const SK_OVERRIDE {
         FCLocker lock;
         return FontConfigTypeface::LegacyCreateTypeface(NULL, familyName,
                                                   (SkTypeface::Style)styleBits);
     }
 };
 
 SkFontMgr* SkFontMgr::Factory() {
     SkFontConfigInterface* fci = RefFCI();
     return fci ? SkNEW_ARGS(SkFontMgr_fontconfig, (fci)) : NULL;
 }