Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Side by Side Diff: runtime/vm/compiler.cc

Issue 849093002: Tweak CanLoadFromObjectPool to return true even if obj.InVMHeap(). (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« runtime/vm/assembler_x64.cc ('K') | « runtime/vm/assembler_x64.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/compiler.h" 5 #include "vm/compiler.h"
6 6
7 #include "vm/assembler.h" 7 #include "vm/assembler.h"
8 8
9 #include "vm/ast_printer.h" 9 #include "vm/ast_printer.h"
10 #include "vm/block_scheduler.h" 10 #include "vm/block_scheduler.h"
(...skipping 832 matching lines...) Expand 10 before | Expand all | Expand 10 after
843 const Array& object_table = Array::Handle(code.object_table()); 843 const Array& object_table = Array::Handle(code.object_table());
844 if (object_table.Length() > 0) { 844 if (object_table.Length() > 0) {
845 OS::Print("Object Table: {\n"); 845 OS::Print("Object Table: {\n");
846 for (intptr_t i = 0; i < object_table.Length(); i++) { 846 for (intptr_t i = 0; i < object_table.Length(); i++) {
847 OS::Print(" %" Pd ": %s\n", i, 847 OS::Print(" %" Pd ": %s\n", i,
848 Object::Handle(object_table.At(i)).ToCString()); 848 Object::Handle(object_table.At(i)).ToCString());
849 } 849 }
850 OS::Print("}\n"); 850 OS::Print("}\n");
851 } 851 }
852 852
853 const Array& object_pool = Array::Handle(
854 Instructions::Handle(code.instructions()).object_pool());
855 if (!object_pool.IsNull() && object_pool.Length() > 0) {
zra 2015/01/14 17:53:24 (object_pool.Length() > 0)
Vyacheslav Egorov (Google) 2015/01/14 17:56:33 Done.
856 OS::Print("Object Pool: {\n");
857 for (intptr_t i = 0; i < object_pool.Length(); i++) {
858 OS::Print(" %" Pd ": %s\n", i,
859 Object::Handle(object_pool.At(i)).ToCString());
860 }
861 OS::Print("}\n");
862 }
863
853 OS::Print("Stackmaps for function '%s' {\n", function_fullname); 864 OS::Print("Stackmaps for function '%s' {\n", function_fullname);
854 if (code.stackmaps() != Array::null()) { 865 if (code.stackmaps() != Array::null()) {
855 const Array& stackmap_table = Array::Handle(code.stackmaps()); 866 const Array& stackmap_table = Array::Handle(code.stackmaps());
856 Stackmap& map = Stackmap::Handle(); 867 Stackmap& map = Stackmap::Handle();
857 for (intptr_t i = 0; i < stackmap_table.Length(); ++i) { 868 for (intptr_t i = 0; i < stackmap_table.Length(); ++i) {
858 map ^= stackmap_table.At(i); 869 map ^= stackmap_table.At(i);
859 OS::Print("%s\n", map.ToCString()); 870 OS::Print("%s\n", map.ToCString());
860 } 871 }
861 } 872 }
862 OS::Print("}\n"); 873 OS::Print("}\n");
(...skipping 328 matching lines...) Expand 10 before | Expand all | Expand 10 after
1191 const Object& result = 1202 const Object& result =
1192 PassiveObject::Handle(isolate->object_store()->sticky_error()); 1203 PassiveObject::Handle(isolate->object_store()->sticky_error());
1193 isolate->object_store()->clear_sticky_error(); 1204 isolate->object_store()->clear_sticky_error();
1194 return result.raw(); 1205 return result.raw();
1195 } 1206 }
1196 UNREACHABLE(); 1207 UNREACHABLE();
1197 return Object::null(); 1208 return Object::null();
1198 } 1209 }
1199 1210
1200 } // namespace dart 1211 } // namespace dart
OLDNEW
« runtime/vm/assembler_x64.cc ('K') | « runtime/vm/assembler_x64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698