Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(737)

Unified Diff: remoting/webapp/unittests/apps_v2_migration_unittest.js

Issue 848993002: Improve apps v2 upgrade UX (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address outstanding feedbacks Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/webapp/crd/js/remoting.js ('k') | remoting/webapp/unittests/chrome_mocks.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/webapp/unittests/apps_v2_migration_unittest.js
diff --git a/remoting/webapp/unittests/apps_v2_migration_unittest.js b/remoting/webapp/unittests/apps_v2_migration_unittest.js
new file mode 100644
index 0000000000000000000000000000000000000000..8ee2a3a0b8ef3b1e347241b008f75bf54d85be46
--- /dev/null
+++ b/remoting/webapp/unittests/apps_v2_migration_unittest.js
@@ -0,0 +1,103 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+(function() {
+
+'use strict';
+
+var mockIsAppsV2 = null;
+var mockChromeStorage = {};
+
+function pass() {
+ ok(true);
+ QUnit.start();
+}
+
+function fail() {
+ ok(false);
+ QUnit.start();
+}
+
+/**
+ * @param {string} v1UserName
+ * @param {string} v1UserEmail
+ * @param {string} currentEmail
+ * @param {boolean} v1HasHost
+ */
+function setMigrationData_(v1UserName, v1UserEmail, v1HasHosts) {
+ remoting.identity.getUserInfo = function(onDone, onError) {
+ if (base.isAppsV2()) {
+ onDone('v2user@gmail.com','v2userName');
+ } else {
+ onDone(v1UserEmail, v1UserName);
+ }
+ };
+
+ mockIsAppsV2.returns(false);
+ if (v1HasHosts) {
+ remoting.AppsV2Migration.saveUserInfo();
+ }
+}
+
+module('AppsV2Migration', {
+ setup: function() {
+ chromeMocks.activate(['storage']);
+ mockIsAppsV2 = sinon.stub(base, 'isAppsV2');
+ remoting.identity = {};
+ },
+ teardown: function() {
+ chromeMocks.restore();
+ mockIsAppsV2.restore();
+ remoting.identity = null;
+ }
+});
+
+QUnit.asyncTest(
+ 'hasHostsInV1App() should reject the promise if v1 user has same identity',
+ function() {
+ setMigrationData_('v1userName', 'v2user@gmail.com', true);
+ mockIsAppsV2.returns(true);
+ remoting.AppsV2Migration.hasHostsInV1App().then(fail, pass);
+});
+
+QUnit.asyncTest(
+ 'hasHostsInV1App() should reject the promise if v1 user has no hosts',
+ function() {
+ setMigrationData_('v1userName', 'v1user@gmail.com', false);
+ mockIsAppsV2.returns(true);
+ remoting.AppsV2Migration.hasHostsInV1App().then(fail, pass);
+});
+
+QUnit.asyncTest(
+ 'hasHostsInV1App() should reject the promise in v1', function() {
+ setMigrationData_('v1userName', 'v1user@gmail.com', true);
+ mockIsAppsV2.returns(false);
+ remoting.AppsV2Migration.hasHostsInV1App().then(fail, pass);
+});
+
+QUnit.asyncTest(
+ 'hasHostsInV1App() should return v1 identity if v1 user has hosts',
+ function() {
+ setMigrationData_('v1userName', 'v1user@gmail.com', true);
+ mockIsAppsV2.returns(true);
+ remoting.AppsV2Migration.hasHostsInV1App().then(
+ function(result) {
+ QUnit.equal(result.email, 'v1user@gmail.com');
+ QUnit.equal(result.fullName, 'v1userName');
+ pass();
+ }, fail
+ );
+});
+
+QUnit.asyncTest(
+ 'saveUserInfo() should clear the preferences on v2',
+ function() {
+ setMigrationData_('v1userName', 'v1user@gmail.com', 'v2user@gmail.com',
+ true);
+ mockIsAppsV2.returns(true);
+ remoting.AppsV2Migration.saveUserInfo(true);
+ remoting.AppsV2Migration.hasHostsInV1App().then(fail, pass);
+});
+
+})();
« no previous file with comments | « remoting/webapp/crd/js/remoting.js ('k') | remoting/webapp/unittests/chrome_mocks.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698