Improve apps v2 upgrade UX

remoting/webapp/crd/js/remoting.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /** @suppress {duplicate} */
 var remoting = remoting || {};
 
 /**
  * @type {base.EventSource} An event source object for handling global events.
  *    This is an interim hack.  Eventually, we should move functionalities
  *    away from the remoting namespace and into smaller objects.
  */
 remoting.testEvents;
 
 /**
  * Initialization tasks that are common to all remoting apps.
  */
 remoting.initGlobalObjects = function() {
   if (base.isAppsV2()) {
     var htmlNode = /** @type {HTMLElement} */ (document.body.parentNode);
     htmlNode.classList.add('apps-v2');
-  } else {
-    migrateLocalToChromeStorage_();
   }
 
   console.log(remoting.getExtensionInfo());
   l10n.localize();
 
   if (base.isAppsV2()) {
     remoting.fullscreen = new remoting.FullscreenAppsV2();
   } else {
     remoting.fullscreen = new remoting.FullscreenAppsV1();
   }
@@ skipping 46 matching lines @@
   var v2OrLegacy = base.isAppsV2() ? " (v2)" : " (legacy)";
   var manifest = chrome.runtime.getManifest();
   if (manifest && manifest.version) {
     var name = chrome.i18n.getMessage('PRODUCT_NAME');
     return name + ' version: ' + manifest.version + v2OrLegacy;
   } else {
     return 'Failed to get product version. Corrupt manifest?';
   }
 };
 
+remoting.onBeforeUnload = function() {

[kelvinp, 2015/01/13 23:05:47]

The 'remoting-email' is not set when initGlobalObjects() got called on
first-run.  If we run the migration in initGlobalObjects(), we would need to at
least run the app twice to the info properly cached.  Doing the migration on
beforeUnload mitigates the problem.

[Jamie, 2015/01/15 20:51:30]

This code is all about moving settings from window.localStorage to
chrome.storage.local. It needs to happen at start of day because we only read
settings from chrome.storage.local.

If it simplifies this CL, I think it's probably safe to remove this migration,
since we've been writing to chrome.storage.local for over a year now, but I
think it should work without needing to change this at all.

+  migrateLocalToChromeStorage_();
+  return remoting.promptClose();
+};
+
 /**
  * If an IT2Me client or host is active then prompt the user before closing.
  * If a Me2Me client is active then don't bother, since closing the window is
  * the more intuitive way to end a Me2Me session, and re-connecting is easy.
+ * @return {?string}
  */
 remoting.promptClose = function() {
   if (remoting.clientSession &&
       remoting.clientSession.getMode() == remoting.ClientSession.Mode.IT2ME) {
     switch (remoting.currentMode) {
       case remoting.AppMode.CLIENT_CONNECTING:
       case remoting.AppMode.HOST_WAITING_FOR_CODE:
       case remoting.AppMode.HOST_WAITING_FOR_CONNECTION:
       case remoting.AppMode.HOST_SHARED:
       case remoting.AppMode.IN_SESSION:
@@ skipping 131 matching lines @@
  * Migrate settings in window.localStorage to chrome.storage.local so that
  * users of older web-apps that used the former do not lose their settings.
  */
 function migrateLocalToChromeStorage_() {
   // The OAuth2 class still uses window.localStorage, so don't migrate any of
   // those settings.
   var oauthSettings = [
       'oauth2-refresh-token',
       'oauth2-refresh-token-revokable',
       'oauth2-access-token',
-      'oauth2-xsrf-token',
-      'remoting-email'

[kelvinp, 2015/01/13 23:05:47]

We need to migrate 'remoting-email' as well.

[Jamie, 2015/01/15 20:51:30]

See above; this is not about migrating settings from v1 to v2, but about
migrating between the legacy and new storage APIs. You shouldn't need to change
any of it.

+      'oauth2-xsrf-token'
   ];
   for (var setting in window.localStorage) {
     if (oauthSettings.indexOf(setting) == -1) {
-      var copy = {}
+      var copy = {};
       copy[setting] = window.localStorage.getItem(setting);
       chrome.storage.local.set(copy);
-      window.localStorage.removeItem(setting);

[Jamie, 2015/01/15 20:51:30]

I don't think you wanted to remove this line.

     }
   }
 }