Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 848973002: Enable strict virtual annotation checks for Mac. (Closed)

Created:
5 years, 11 months ago by dcheng
Modified:
5 years, 11 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable strict virtual annotation checks for Mac. BUG=417463 Committed: https://crrev.com/3e6c4cf39b9c06c2b23b7e301b1f197902f1cc2d Cr-Commit-Position: refs/heads/master@{#311365}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
dcheng
5 years, 11 months ago (2015-01-13 21:57:19 UTC) #2
Nico
lgtm \o/
5 years, 11 months ago (2015-01-13 21:58:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/848973002/1
5 years, 11 months ago (2015-01-13 21:59:56 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/48678)
5 years, 11 months ago (2015-01-13 22:55:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/848973002/1
5 years, 11 months ago (2015-01-13 23:00:11 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-14 00:04:54 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 00:05:36 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3e6c4cf39b9c06c2b23b7e301b1f197902f1cc2d
Cr-Commit-Position: refs/heads/master@{#311365}

Powered by Google App Engine
This is Rietveld 408576698