Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 848963002: Fix official Mac build for strict virtual annotations check. (Closed)

Created:
5 years, 11 months ago by dcheng
Modified:
5 years, 11 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix official Mac build for strict virtual annotations check. BUG=417463 Committed: https://crrev.com/b342dc7032ce1287ae587e9db769f169806fc39d Cr-Commit-Position: refs/heads/master@{#311354}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -18 lines) Patch
M chrome/browser/component_updater/widevine_cdm_component_installer.cc View 1 chunk +8 lines, -8 lines 1 comment Download
M chrome/browser/rlz/rlz.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/rlz/rlz_unittest.cc View 4 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
dcheng
5 years, 11 months ago (2015-01-13 21:51:42 UTC) #2
Nico
lgtm (how long was this broken?)
5 years, 11 months ago (2015-01-13 21:52:47 UTC) #3
dcheng
https://codereview.chromium.org/848963002/diff/1/chrome/browser/component_updater/widevine_cdm_component_installer.cc File chrome/browser/component_updater/widevine_cdm_component_installer.cc (right): https://codereview.chromium.org/848963002/diff/1/chrome/browser/component_updater/widevine_cdm_component_installer.cc#newcode237 chrome/browser/component_updater/widevine_cdm_component_installer.cc:237: ~WidevineCdmComponentInstallerTraits() override {} Note: I left this due to ...
5 years, 11 months ago (2015-01-13 21:52:52 UTC) #4
dcheng
Mac switch hasn't been flipped yet =)
5 years, 11 months ago (2015-01-13 21:53:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/848963002/1
5 years, 11 months ago (2015-01-13 21:56:20 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-13 22:57:58 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-13 22:58:41 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b342dc7032ce1287ae587e9db769f169806fc39d
Cr-Commit-Position: refs/heads/master@{#311354}

Powered by Google App Engine
This is Rietveld 408576698