Drop (empty) virtual destructor from Iterable<> class

Drop (empty) virtual destructor from Iterable<> class

It's not needed, and needlessly taints garbage collected sub-classes such
that they need to be marked as "finalized".

BUG=432683
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188636

[Jens Widell, 2015-01-19 13:52:19]

jl@opera.com changed reviewers:
+ haraken@chromium.org, yhirano@chromium.org

[Jens Widell, 2015-01-19 13:52:19]

PTAL

I don't know if this is considered a good thing or a bad thing.

I only added the virtual destructor since the class defines other virtual
functions, assuming not having it would lead to compiler warnings. That's
apparently not the case, though.

Having the destructor is a bit unfortunate, since this means sub-classes may
require (Oilpan-)finalization only because of this virtual destructor, such as
is the case for Headers. (I made Headers finalized in issue 848673002, which
added Iterable<>.)

[haraken, 2015-01-19 13:57:51]

LGTM. If something in the Iterable hierarchy requires finalization, the GC
plugin will complain about it (I hope so).

[haraken, 2015-01-19 13:57:58]

haraken@chromium.org changed reviewers:
+ oilpan-reviews@chromium.org

[Jens Widell, 2015-01-19 14:03:54]

The CQ bit was checked by jl@opera.com

[commit-bot: I haz the power, 2015-01-19 14:04:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/848953003/1

[commit-bot: I haz the power, 2015-01-19 16:32:06]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188636