Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 848953002: [Ozone-Demo] Initialize a default keyboard layout (Closed)

Created:
5 years, 11 months ago by dnicoara
Modified:
5 years, 11 months ago
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@fix-surfaceless-demo
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Ozone-Demo] Initialize a default keyboard layout There is no default layout, so if we don't initialize one then all the key events will be ignored. BUG=none NOTRY=true Committed: https://crrev.com/6e408ee876911e148db5dffafefae10a72ff7da5 Cr-Commit-Position: refs/heads/master@{#311407}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M ui/ozone/demo/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/ozone/demo/ozone_demo.cc View 2 chunks +4 lines, -0 lines 2 comments Download
M ui/ozone/demo/ozone_demos.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
dnicoara
5 years, 11 months ago (2015-01-13 21:37:50 UTC) #2
alexst (slow to review)
https://codereview.chromium.org/848953002/diff/1/ui/ozone/demo/ozone_demo.cc File ui/ozone/demo/ozone_demo.cc (right): https://codereview.chromium.org/848953002/diff/1/ui/ozone/demo/ozone_demo.cc#newcode142 ui/ozone/demo/ozone_demo.cc:142: ->SetCurrentLayoutByName("us"); Is "us" a know string or is it ...
5 years, 11 months ago (2015-01-13 21:41:31 UTC) #3
dnicoara
https://codereview.chromium.org/848953002/diff/1/ui/ozone/demo/ozone_demo.cc File ui/ozone/demo/ozone_demo.cc (right): https://codereview.chromium.org/848953002/diff/1/ui/ozone/demo/ozone_demo.cc#newcode142 ui/ozone/demo/ozone_demo.cc:142: ->SetCurrentLayoutByName("us"); On 2015/01/13 21:41:31, alexst wrote: > Is "us" ...
5 years, 11 months ago (2015-01-13 21:46:04 UTC) #4
alexst (slow to review)
lgtm
5 years, 11 months ago (2015-01-13 21:48:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/848953002/1
5 years, 11 months ago (2015-01-14 03:55:05 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-14 03:55:53 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 03:57:39 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6e408ee876911e148db5dffafefae10a72ff7da5
Cr-Commit-Position: refs/heads/master@{#311407}

Powered by Google App Engine
This is Rietveld 408576698