Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 848943003: Fix typo in js code when checking the origin of a message coming from the (Closed)

Created:
5 years, 11 months ago by Roger Tawa OOO till Jul 10th
Modified:
5 years, 11 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, arv+watch_chromium.org, Dmitry Polukhin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix typo in js code when checking the origin of a message coming from the embedded webview. The length of the string was not correctly calculated. BUG=None Committed: https://crrev.com/238a196c42ae644171f96697a828a11d6478f178 Cr-Commit-Position: refs/heads/master@{#311488}

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/gaia_auth_host/authenticator.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
Roger Tawa OOO till Jul 10th
Hi Xiyuan, Can you review this typo in the js authenticator code? I found this ...
5 years, 11 months ago (2015-01-13 19:42:20 UTC) #2
xiyuan
lgtm
5 years, 11 months ago (2015-01-13 20:17:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/848943003/1
5 years, 11 months ago (2015-01-14 00:14:38 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/48746)
5 years, 11 months ago (2015-01-14 00:29:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/848943003/20001
5 years, 11 months ago (2015-01-14 16:26:24 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-14 16:30:29 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 16:31:47 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/238a196c42ae644171f96697a828a11d6478f178
Cr-Commit-Position: refs/heads/master@{#311488}

Powered by Google App Engine
This is Rietveld 408576698