Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Issue 848933002: [Cronet] Remove assertion on exception message description (Closed)

Created:
5 years, 11 months ago by xunjieli
Modified:
5 years, 11 months ago
Reviewers:
pauljensen, mef, mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cronet] Remove assertion on exception message description This CL is to fix crash in cronet builder, http://build.chromium.org/p/chromium.fyi/builders/Android%20Cronet%20Builder/builds/6248 Committed: https://crrev.com/ba789d07fb0ef6da96c1ba2818ddad3f70dca950 Cr-Commit-Position: refs/heads/master@{#311330}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/urlconnection/CronetHttpURLConnectionTest.java View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
xunjieli
In CronetHttpURLConnection#testBadHostname, Cronet's implementation is expecting net::ERR_NAME_NOT_RESOLVED, but it gets net::ERR_INTERNET_DISCONNECTED on buildbot (http://build.chromium.org/p/chromium.fyi/builders/Android%20Cronet%20Builder/builds/6248/steps/test%20CronetTest/logs/stdio). Removing ...
5 years, 11 months ago (2015-01-13 18:57:30 UTC) #2
mmenke
On 2015/01/13 18:57:30, xunjieli wrote: > In CronetHttpURLConnection#testBadHostname, Cronet's implementation is expecting > net::ERR_NAME_NOT_RESOLVED, but ...
5 years, 11 months ago (2015-01-13 18:59:45 UTC) #3
xunjieli
On 2015/01/13 18:59:45, mmenke wrote: > On 2015/01/13 18:57:30, xunjieli wrote: > > In CronetHttpURLConnection#testBadHostname, ...
5 years, 11 months ago (2015-01-13 19:04:17 UTC) #4
mef
lgtm
5 years, 11 months ago (2015-01-13 20:23:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/848933002/1
5 years, 11 months ago (2015-01-13 20:25:10 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-13 21:42:29 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-13 21:43:10 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ba789d07fb0ef6da96c1ba2818ddad3f70dca950
Cr-Commit-Position: refs/heads/master@{#311330}

Powered by Google App Engine
This is Rietveld 408576698