Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 848923004: Make all SafeBrowsing* unit_tests work under AddressSanitizer on Windows (Closed)

Created:
5 years, 11 months ago by Timur Iskhodzhanov
Modified:
5 years, 11 months ago
CC:
chromium-reviews, grt+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make all SafeBrowsing* unit_tests work under AddressSanitizer on Windows AddressSanitizer (ASan) uses code patching of every module of an application at startup / module load. As a result, many tests that check the number of modified functions misbehave. I'm disabling most of them and adjusting one that's easy to generalize. I've also replaced some EXPECT_* macros with ASSERT_* per https://code.google.com/p/googletest/wiki/V1_7_Primer#Assertions "you should use ASSERT_* if it doesn't make sense to continue when the assertion in question fails" BUG=345874 Committed: https://crrev.com/12a841b4008156472c958074ed491e11acbc247e Cr-Commit-Position: refs/heads/master@{#311452}

Patch Set 1 #

Total comments: 2

Patch Set 2 : address the comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -10 lines) Patch
M chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win_unittest.cc View 4 chunks +10 lines, -4 lines 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/module_integrity_verifier_win_unittest.cc View 1 4 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Timur Iskhodzhanov
5 years, 11 months ago (2015-01-13 20:07:46 UTC) #2
grt (UTC plus 2)
lgtm w/ a nit https://codereview.chromium.org/848923004/diff/1/chrome/browser/safe_browsing/incident_reporting/module_integrity_verifier_win_unittest.cc File chrome/browser/safe_browsing/incident_reporting/module_integrity_verifier_win_unittest.cc (right): https://codereview.chromium.org/848923004/diff/1/chrome/browser/safe_browsing/incident_reporting/module_integrity_verifier_win_unittest.cc#newcode155 chrome/browser/safe_browsing/incident_reporting/module_integrity_verifier_win_unittest.cc:155: #endif nit: #endif // ADDRESS_SANITIZER
5 years, 11 months ago (2015-01-13 20:15:51 UTC) #3
robertshield
lgtm
5 years, 11 months ago (2015-01-13 20:25:56 UTC) #4
Timur Iskhodzhanov
Thanks for the quick review! https://codereview.chromium.org/848923004/diff/1/chrome/browser/safe_browsing/incident_reporting/module_integrity_verifier_win_unittest.cc File chrome/browser/safe_browsing/incident_reporting/module_integrity_verifier_win_unittest.cc (right): https://codereview.chromium.org/848923004/diff/1/chrome/browser/safe_browsing/incident_reporting/module_integrity_verifier_win_unittest.cc#newcode155 chrome/browser/safe_browsing/incident_reporting/module_integrity_verifier_win_unittest.cc:155: #endif Oops, I always ...
5 years, 11 months ago (2015-01-14 10:20:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/848923004/20001
5 years, 11 months ago (2015-01-14 10:22:14 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-14 11:21:03 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 11:22:11 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/12a841b4008156472c958074ed491e11acbc247e
Cr-Commit-Position: refs/heads/master@{#311452}

Powered by Google App Engine
This is Rietveld 408576698