DescriptionMake all SafeBrowsing* unit_tests work under AddressSanitizer on Windows
AddressSanitizer (ASan) uses code patching of every module of an application at startup / module load.
As a result, many tests that check the number of modified functions misbehave.
I'm disabling most of them and adjusting one that's easy to generalize.
I've also replaced some EXPECT_* macros with ASSERT_* per
https://code.google.com/p/googletest/wiki/V1_7_Primer#Assertions
"you should use ASSERT_* if it doesn't make sense to continue when the assertion in question fails"
BUG=345874
Committed: https://crrev.com/12a841b4008156472c958074ed491e11acbc247e
Cr-Commit-Position: refs/heads/master@{#311452}
Patch Set 1 #
Total comments: 2
Patch Set 2 : address the comment #
Messages
Total messages: 9 (2 generated)
|