Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 848913003: Reland Auto-generate v8 version based on tags. (Closed)

Created:
5 years, 11 months ago by Michael Achenbach
Modified:
5 years, 11 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland Auto-generate v8 version based on tags. BUG=chromium:446166 LOG=n

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -16 lines) Patch
M BUILD.gn View 4 chunks +21 lines, -1 line 0 comments Download
M tools/gyp/v8.gyp View 4 chunks +35 lines, -1 line 0 comments Download
M tools/push-to-trunk/generate_version.py View 2 chunks +19 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Michael Achenbach
Created Revert of Revert of Auto-generate v8 version based on tags.
5 years, 11 months ago (2015-01-15 08:37:36 UTC) #1
tandrii_google
lgtm
5 years, 11 months ago (2015-01-15 09:24:04 UTC) #3
Michael Achenbach
5 years, 11 months ago (2015-01-15 13:31:35 UTC) #4
Oops, didn't mean to send a mail for this one. Will reup a fixed version.

Powered by Google App Engine
This is Rietveld 408576698