Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 848903002: Extract UnitTestLauncherDelegate declaration to a header (Closed)

Created:
5 years, 11 months ago by Paweł Hajdan Jr.
Modified:
5 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Extract UnitTestLauncherDelegate declaration to a header This is a preparation for defining some methods in an ios-specific .cc file. BUG=426870 R=sky@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/49adb29e8bb25a51b5dc01d692a3acad717553e6

Patch Set 1 #

Total comments: 2

Patch Set 2 : disallow #

Unified diffs Side-by-side diffs Delta from patch set Stats (+230 lines, -174 lines) Patch
M base/test/launcher/unit_test_launcher.h View 1 2 chunks +70 lines, -0 lines 0 comments Download
M base/test/launcher/unit_test_launcher.cc View 8 chunks +160 lines, -174 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Paweł Hajdan Jr.
5 years, 11 months ago (2015-01-13 16:18:37 UTC) #2
sky
LGTM https://codereview.chromium.org/848903002/diff/1/base/test/launcher/unit_test_launcher.h File base/test/launcher/unit_test_launcher.h (right): https://codereview.chromium.org/848903002/diff/1/base/test/launcher/unit_test_launcher.h#newcode100 base/test/launcher/unit_test_launcher.h:100: }; DISALLOW..
5 years, 11 months ago (2015-01-13 18:38:47 UTC) #3
Paweł Hajdan Jr.
https://codereview.chromium.org/848903002/diff/1/base/test/launcher/unit_test_launcher.h File base/test/launcher/unit_test_launcher.h (right): https://codereview.chromium.org/848903002/diff/1/base/test/launcher/unit_test_launcher.h#newcode100 base/test/launcher/unit_test_launcher.h:100: }; On 2015/01/13 18:38:47, sky wrote: > DISALLOW.. Done.
5 years, 11 months ago (2015-01-14 09:21:33 UTC) #4
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/49adb29e8bb25a51b5dc01d692a3acad717553e6 Cr-Commit-Position: refs/heads/master@{#311440}
5 years, 11 months ago (2015-01-14 10:09:41 UTC) #5
Paweł Hajdan Jr.
5 years, 11 months ago (2015-01-14 10:09:51 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
49adb29e8bb25a51b5dc01d692a3acad717553e6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698