Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 848873002: Fix the compilation error for turbofan unsupported platform. (Closed)

Created:
5 years, 11 months ago by chunyang.dai
Modified:
5 years, 11 months ago
Reviewers:
titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix the compilation error for turbofan unsupported platform. Fix the compilation error for turbofan unsupported platform. The Linkage::GetOsrValuePosition() function is implemented in linkage-impl.h. And this file is included by different platform specific file separately. This leads to compilation error for turbofan unsupported platform. The fix is adding one dummy implementation in linkage.cc. BUG= Committed: https://crrev.com/728b39573cc1512c738c782b26f990a6838ec51e Cr-Commit-Position: refs/heads/master@{#26041}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M src/compiler/linkage.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
hi, PTAL. thanks
5 years, 11 months ago (2015-01-13 12:22:58 UTC) #2
titzer
lgtm
5 years, 11 months ago (2015-01-13 12:44:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/848873002/1
5 years, 11 months ago (2015-01-13 12:45:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-13 13:12:32 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-13 13:12:41 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/728b39573cc1512c738c782b26f990a6838ec51e
Cr-Commit-Position: refs/heads/master@{#26041}

Powered by Google App Engine
This is Rietveld 408576698