Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1562)

Unified Diff: ppapi/proxy/image_capture_resource.h

Issue 848863002: PPAPI: implement GetSupportedPreviewSizes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix a compile error Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/proxy/image_capture_resource.h
diff --git a/ppapi/proxy/image_capture_resource.h b/ppapi/proxy/image_capture_resource.h
new file mode 100644
index 0000000000000000000000000000000000000000..ca0ba2d71f65df530bd5aa717fb85d6552e565f9
--- /dev/null
+++ b/ppapi/proxy/image_capture_resource.h
@@ -0,0 +1,71 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef PPAPI_PROXY_IMAGE_CAPTURE_RESOURCE_H_
+#define PPAPI_PROXY_IMAGE_CAPTURE_RESOURCE_H_
+
+#include "base/basictypes.h"
+#include "base/memory/scoped_ptr.h"
dmichael (off chromium) 2015/02/09 22:27:00 nit: Not using this header
Justin Chuang 2015/02/10 16:01:02 Done.
+#include "ppapi/c/pp_size.h"
+#include "ppapi/proxy/connection.h"
+#include "ppapi/proxy/plugin_resource.h"
+#include "ppapi/proxy/ppapi_proxy_export.h"
+#include "ppapi/shared_impl/resource.h"
+#include "ppapi/thunk/ppb_image_capture_api.h"
+
+namespace ppapi {
+namespace proxy {
+
+class CameraCapabilitiesResource;
+class ImageCaptureConfigResource;
+
+class PPAPI_PROXY_EXPORT ImageCaptureResource
+ : public PluginResource,
+ public thunk::PPB_ImageCapture_API {
+ public:
+ ImageCaptureResource(Connection connection, PP_Instance instance);
+ virtual ~ImageCaptureResource();
dmichael (off chromium) 2015/02/09 22:27:00 This should be override (not marked virtual). Same
Justin Chuang 2015/02/10 16:01:03 Done. Thank you! I haven't noticed this rule also
+
+ // Resource overrides:
+ virtual thunk::PPB_ImageCapture_API* AsPPB_ImageCapture_API() override {
dmichael (off chromium) 2015/02/09 22:27:00 We should only mark a function virtual OR override
Justin Chuang 2015/02/10 16:01:02 Done in this file and the other files.
+ return this;
+ }
+
+ // PPB_ImageCapture_API overrides:
+ virtual int32_t Open(PP_Var device_id,
+ scoped_refptr<TrackedCallback> callback) override;
+ virtual void Close() override;
+ virtual int32_t GetCameraCapabilities(
+ PP_Resource* capabilities,
+ scoped_refptr<TrackedCallback> callback) override;
dmichael (off chromium) 2015/02/09 22:27:00 nit: Maybe slightly prefer const scoped_refptr<>&
Justin Chuang 2015/02/10 16:01:03 Done.
+
+ private:
+ enum OpenState { BEFORE_OPEN, OPENED, CLOSED };
+
+ // Host -> plugin messages.
+ void OnPluginMsgGetPreviewSizesReply(
+ const ResourceMessageReplyParams& params,
+ const std::vector<PP_Size>& preview_sizes);
+
+ // reply to open
dmichael (off chromium) 2015/02/09 22:27:00 You could leave out this comment and just put this
Justin Chuang 2015/02/10 16:01:03 Removed the comments and blank line.
+ void OnPluginMsgOpenReply(const ResourceMessageReplyParams& params);
+
+ // other
dmichael (off chromium) 2015/02/09 22:27:00 unnecessary comment
Justin Chuang 2015/02/10 16:01:03 Done.
+ bool IsOpened() const { return open_state_ == OPENED; }
dmichael (off chromium) 2015/02/09 22:27:00 nit: I'm used to seeing simple inlined functions l
Justin Chuang 2015/02/10 16:01:02 It's true. Done.
+
+ // Holds a reference of the callback so that Close() can cancel it.
+ scoped_refptr<TrackedCallback> open_callback_;
+ OpenState open_state_;
+
+ PP_Resource* get_capabilities_output_;
+ scoped_refptr<TrackedCallback> get_capabilities_callback_;
+ scoped_refptr<CameraCapabilitiesResource> camera_capabilities_;
+
+ DISALLOW_COPY_AND_ASSIGN(ImageCaptureResource);
+};
+
+} // namespace proxy
+} // namespace ppapi
+
+#endif // PPAPI_PROXY_IMAGE_CAPTURE_RESOURCE_H_

Powered by Google App Engine
This is Rietveld 408576698