Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Side by Side Diff: ppapi/proxy/camera_capabilities_resource.cc

Issue 848863002: PPAPI: implement GetSupportedPreviewSizes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix compile error on Linux build Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "base/logging.h"
6 #include "ppapi/proxy/camera_capabilities_resource.h"
7
8 namespace ppapi {
9 namespace proxy {
10
11 CameraCapabilitiesResource::CameraCapabilitiesResource(PP_Instance instance)
12 : Resource(OBJECT_IS_PROXY, instance),
13 num_preview_sizes_(0),
14 num_jpeg_sizes_(0) {
15 }
16
17 CameraCapabilitiesResource::~CameraCapabilitiesResource() {
18 }
19
20 thunk::PPB_CameraCapabilities_API*
21 CameraCapabilitiesResource::AsPPB_CameraCapabilities_API() {
22 return this;
23 }
24
25 void CameraCapabilitiesResource::GetSupportedPreviewSizes(
26 int32_t* array_size,
27 PP_Size** preview_sizes) {
28 *array_size = num_preview_sizes_;
29 *preview_sizes = preview_sizes_.get();
30 }
31
32 void CameraCapabilitiesResource::GetSupportedJpegSizes(int32_t* array_size,
33 PP_Size** jpeg_sizes) {
34 *array_size = num_jpeg_sizes_;
35 *jpeg_sizes = jpeg_sizes_.get();
36 }
37
38 void CameraCapabilitiesResource::SetPreviewSizes(
wuchengli 2015/01/19 14:05:03 SetXXX usually implies this can be called more tha
Justin Chuang 2015/01/26 15:00:51 You are right. Actually I found I should do it in
39 const std::vector<PP_Size>& sizes) {
40 num_preview_sizes_ = sizes.size();
41 DCHECK(!preview_sizes_.get()); // only initialized once
wuchengli 2015/01/19 14:05:03 s/initialized/initialize/.
42 preview_sizes_.reset(new PP_Size[num_preview_sizes_]);
43 for (int i = 0; i < num_preview_sizes_; i++)
44 preview_sizes_[i] = sizes[i];
45 }
46
47 void CameraCapabilitiesResource::SetJpegSizes(
48 const std::vector<PP_Size>& sizes) {
49 num_jpeg_sizes_ = sizes.size();
50 DCHECK(!jpeg_sizes_.get()); // only initialized once
51 jpeg_sizes_.reset(new PP_Size[num_jpeg_sizes_]);
52 for (int i = 0; i < num_jpeg_sizes_; i++)
53 jpeg_sizes_[i] = sizes[i];
54 }
55
56 } // namespace proxy
57 } // namespace ppapi
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698