PPAPI: implement GetSupportedPreviewSizes

ppapi/cpp/private/image_capture_private.cc

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "ppapi/cpp/private/image_capture_private.h"
+
+#include "ppapi/c/pp_bool.h"
+#include "ppapi/c/pp_errors.h"
+#include "ppapi/cpp/completion_callback.h"
+#include "ppapi/cpp/instance_handle.h"
+#include "ppapi/cpp/module_impl.h"
+#include "ppapi/cpp/private/camera_capabilities_private.h"
+
+namespace pp {
+
+namespace {
+
+template <>
+const char* interface_name<PPB_ImageCapture_Private_0_1>() {
+  return PPB_IMAGECAPTURE_PRIVATE_INTERFACE_0_1;
+}
+
+}  // namespace
+
+ImageCapture_Private::ImageCapture_Private() {
+}
+
+ImageCapture_Private::ImageCapture_Private(const ImageCapture_Private& other)
+    : Resource(other) {
+}
+
+ImageCapture_Private::ImageCapture_Private(const Resource& resource)
+    : Resource(resource) {
+  PP_DCHECK(IsImageCapture(resource));
+}
+
+ImageCapture_Private::ImageCapture_Private(const InstanceHandle& instance) {
+  if (has_interface<PPB_ImageCapture_Private_0_1>()) {
+    PassRefFromConstructor(
+        get_interface<PPB_ImageCapture_Private_0_1>()->Create(
+            instance.pp_instance()));
+    return;
+  }
+  PP_DCHECK(false);
+}
+
+ImageCapture_Private::ImageCapture_Private(PassRef, PP_Resource resource)
+    : Resource(PASS_REF, resource) {
+}
+
+ImageCapture_Private::~ImageCapture_Private() {
+}
+
+int32_t ImageCapture_Private::Open(const Var& device_id,
+                                   const CompletionCallback& callback) {
+  if (!has_interface<PPB_ImageCapture_Private_0_1>())
+    return PP_ERROR_NOINTERFACE;

[dmichael (off chromium), 2015/02/09 22:26:59]

You should use callback.MayForce here and in other C++ methods with completion
callbacks. It will make the callback run asynchronously if it's a callback
that's required to be async.

[Justin Chuang, 2015/02/10 16:01:02]

Done.

+
+  return get_interface<PPB_ImageCapture_Private_0_1>()->Open(
+      pp_resource(), device_id.pp_var(), callback.pp_completion_callback());
+}
+
+void ImageCapture_Private::Close() {
+  if (has_interface<PPB_ImageCapture_Private_0_1>()) {
+    get_interface<PPB_ImageCapture_Private_0_1>()->Close(pp_resource());
+  }

[dmichael (off chromium), 2015/02/09 22:26:59]

nit: no curly braces here, for consistency

[Justin Chuang, 2015/02/10 16:01:02]

Done.

+}
+
+int32_t ImageCapture_Private::GetCameraCapabilities(
+    const CompletionCallbackWithOutput<CameraCapabilities_Private>& callback) {
+  if (!has_interface<PPB_ImageCapture_Private_0_1>())
+    return PP_ERROR_NOINTERFACE;
+
+  return get_interface<PPB_ImageCapture_Private_0_1>()->GetCameraCapabilities(
+      pp_resource(), callback.output(), callback.pp_completion_callback());
+}
+
+// static
+bool ImageCapture_Private::IsImageCapture(const Resource& resource) {
+  if (!has_interface<PPB_ImageCapture_Private_0_1>())
+    return false;
+
+  return PP_ToBool(
+      get_interface<PPB_ImageCapture_Private_0_1>()->IsImageCapture(
+          resource.pp_resource()));
+}
+
+}  // namespace pp