Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 848853004: Support :hover/:active in quirks when leftmost in compound. (Closed)

Created:
5 years, 11 months ago by rune
Modified:
5 years, 11 months ago
Reviewers:
kochi
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Support :hover/:active in quirks when leftmost in compound. SelectorChecker checked if there was a simple selector to the left of :hover/:active. Added check for simple selector to the right too. The relevant spec is [1]. [1] https://quirks.spec.whatwg.org/#the-:active-and-:hover-quirk BUG=448325, 448049 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188465

Patch Set 1 #

Total comments: 2

Patch Set 2 : Moved comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -6 lines) Patch
A LayoutTests/fast/css/hover-leftmost-quirks.html View 1 chunk +34 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/hover-leftmost-quirks-expected.txt View 1 chunk +18 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/hover-pseudo-element-quirks.html View 1 chunk +29 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/hover-pseudo-element-quirks-expected.txt View 1 chunk +14 lines, -0 lines 0 comments Download
M Source/core/css/SelectorChecker.h View 1 2 chunks +9 lines, -0 lines 0 comments Download
M Source/core/css/SelectorChecker.cpp View 1 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
rune
5 years, 11 months ago (2015-01-13 12:37:15 UTC) #2
kochi
LGTM https://codereview.chromium.org/848853004/diff/1/Source/core/css/SelectorChecker.cpp File Source/core/css/SelectorChecker.cpp (right): https://codereview.chromium.org/848853004/diff/1/Source/core/css/SelectorChecker.cpp#newcode783 Source/core/css/SelectorChecker.cpp:783: // href and *:hover should not match anything. ...
5 years, 11 months ago (2015-01-15 10:04:11 UTC) #3
rune
https://codereview.chromium.org/848853004/diff/1/Source/core/css/SelectorChecker.cpp File Source/core/css/SelectorChecker.cpp (right): https://codereview.chromium.org/848853004/diff/1/Source/core/css/SelectorChecker.cpp#newcode783 Source/core/css/SelectorChecker.cpp:783: // href and *:hover should not match anything. This ...
5 years, 11 months ago (2015-01-15 10:29:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/848853004/20001
5 years, 11 months ago (2015-01-15 10:29:41 UTC) #6
kochi
On 2015/01/15 10:29:03, rune wrote: > https://codereview.chromium.org/848853004/diff/1/Source/core/css/SelectorChecker.cpp > File Source/core/css/SelectorChecker.cpp (right): > > https://codereview.chromium.org/848853004/diff/1/Source/core/css/SelectorChecker.cpp#newcode783 > ...
5 years, 11 months ago (2015-01-15 10:30:39 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-15 11:57:22 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188465

Powered by Google App Engine
This is Rietveld 408576698