Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 848853003: Revert of Relanding 'Always notify the MediaPlayer of any seek' patch (Closed)

Created:
5 years, 11 months ago by Srirama
Modified:
5 years, 11 months ago
CC:
blink-reviews, blink-reviews-html_chromium.org, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, nessy, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Relanding 'Always notify the MediaPlayer of any seek' patch (patchset #8 id:180001 of https://codereview.chromium.org/456343002/) Reason for revert: Android perf bots failure in media.android.tough_video_cases (timeout) https://code.google.com/p/chromium/issues/detail?id=448092 Original issue's description: > Relanding 'Always notify the MediaPlayer of any seek' patch > > This change removes short circuit logic for seeking to the current position. > There are certain situations, like seeking to a truncated duration, where the > HTMLMediaElement is not in the best position to determine whether a call to > the MediaPlayer is necessary or not. This change allows the > MediaPlayer/WebMediaPlayer implementation to determine what the best course > of action should be. This also makes the seeking behavior more spec > compliant because even a seek to the current position should have the > seeking attribute be true until a stable state occurs. This is guaranteed > when calling into the MediaPlayer and allows all seeks to be treated the > same at the HTMLMediaElement level. > > BUG=266631 > TEST=LayoutTests/media/video-seek-to-current-position.html > > Original CL: https://codereview.chromium.org/431903003/ > > Depends on the chromium patch https://codereview.chromium.org/685993002/ > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188150 TBR=philipj@opera.com,dalecurtis@chromium.org NOTREECHECKS=true NOTRY=true BUG=266631 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188281

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -115 lines) Patch
M LayoutTests/media/controls-timeline-with-controller.html View 2 chunks +1 line, -7 lines 0 comments Download
M LayoutTests/media/controls-timeline-with-controller-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/media/media-controller-effective-playback-rate.html View 2 chunks +7 lines, -6 lines 0 comments Download
M LayoutTests/media/media-controller-effective-playback-rate-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/media/media-controller-playbackrate.html View 2 chunks +7 lines, -15 lines 0 comments Download
M LayoutTests/media/media-controller-playbackrate-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/media/video-seek-to-current-position.html View 1 chunk +0 lines, -56 lines 0 comments Download
D LayoutTests/media/video-seek-to-current-position-expected.txt View 1 chunk +0 lines, -24 lines 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 2 chunks +20 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Srirama
Created Revert of Relanding 'Always notify the MediaPlayer of any seek' patch
5 years, 11 months ago (2015-01-13 09:47:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/848853003/1
5 years, 11 months ago (2015-01-13 09:48:30 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=188281
5 years, 11 months ago (2015-01-13 09:49:17 UTC) #3
philipj_slow
5 years, 11 months ago (2015-01-13 09:51:21 UTC) #4
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698