Source/core/editing/VisibleSelection.cpp - Issue 848843002: VisibleSelection::nonBoundaryShadowTreeRootNode should return null when its anchor is a shadow root

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/VisibleSelection.cpp

Issue 848843002: VisibleSelection::nonBoundaryShadowTreeRootNode should return null when its anchor is a shadow root (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/editing/VisibleSelection.cpp

diff --git a/Source/core/editing/VisibleSelection.cpp b/Source/core/editing/VisibleSelection.cpp

index 457599ab18c25c7db70979605ef9d6a4bffcda77..59339545d0fffba9c8364456f7885d74c2857eed 100644

--- a/Source/core/editing/VisibleSelection.cpp

+++ b/Source/core/editing/VisibleSelection.cpp

@@ -752,7 +752,7 @@ Element* VisibleSelection::rootEditableElement() const

Node* VisibleSelection::nonBoundaryShadowTreeRootNode() const

{

- return start().deprecatedNode() ? start().deprecatedNode()->nonBoundaryShadowTreeRootNode() : 0;

+ return start().deprecatedNode() && !start().deprecatedNode()->isShadowRoot() ? start().deprecatedNode()->nonBoundaryShadowTreeRootNode() : 0;

}

VisibleSelection::ChangeObserver::ChangeObserver()

« no previous file with comments | « LayoutTests/fast/forms/ua-shadow-select-all-crash-expected.txt ('k') | no next file » | no next file with comments »