LayoutTests/fast/forms/ua-shadow-select-all-crash.html - Issue 848843002: VisibleSelection::nonBoundaryShadowTreeRootNode should return null when its anchor is a shadow root

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/forms/ua-shadow-select-all-crash.html

Issue 848843002: VisibleSelection::nonBoundaryShadowTreeRootNode should return null when its anchor is a shadow root (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <html>
	yosin_UTC9 2015/01/14 01:33:44 nit: Could you add "<!DOCTYPE html>" to make Blink nit: Could you add "<!DOCTYPE html>" to make Blink parser in strict mode? keishi 2015/01/16 05:08:41 Done. Show quoted text On 2015/01/14 01:33:44, Yosi_UTC9 wrote: > nit: Could you add "<!DOCTYPE html>" to make Blink parser in strict mode? Done.
	2 <body>

	3 <button type="button" id="button1">FOOO</button>

	4

	5 <script>

	6 var button1 = document.getElementById('button1');

	7 var input1=document.createElement('input');
	yosin_UTC9 2015/01/14 01:33:44 nit: Please put spaces around \|=\| nit: Please put spaces around \|=\| keishi 2015/01/16 05:08:41 Done. Show quoted text On 2015/01/14 01:33:44, Yosi_UTC9 wrote: > nit: Please put spaces around \|=\| Done.
	8 button1.appendChild(input1);
	yosin_UTC9 2015/01/14 01:33:44 Can we put <input type="week"> in markup rather th Can we put <input type="week"> in markup rather than constructing in script? keishi 2015/01/16 05:08:41 Done. Changing the type later is the important bit Show quoted text On 2015/01/14 01:33:44, Yosi_UTC9 wrote: > Can we put <input type="week"> in markup rather than constructing in script? Done. Changing the type later is the important bit so I added <input type=text> in markup
	9 input1.setSelectionRange(0);

	10 input1.type='week';
	yosin_UTC9 2015/01/14 01:33:44 nit: Please put spaces around \|=\| nit: Please put spaces around \|=\| keishi 2015/01/16 05:08:41 Done. Show quoted text On 2015/01/14 01:33:44, Yosi_UTC9 wrote: > nit: Please put spaces around \|=\| Done.
	11 var oSelection = window.getSelection();

	12 document.execCommand('SelectAll', false, false);
	yosin_UTC9 2015/01/14 01:33:44 nit: We need first argument only. nit: We need first argument only. keishi 2015/01/16 05:08:41 Done. Show quoted text On 2015/01/14 01:33:44, Yosi_UTC9 wrote: > nit: We need first argument only. Done.
	13 oSelection.deleteFromDocument();

	14 input1.value = 'foo';

	15 </script>

	16 <p>Pass if it doesn't crash</p>

	17 </body>

	18 </html>

OLD	NEW

« no previous file with comments | « no previous file | Source/core/editing/VisibleSelection.cpp » ('j') | Source/core/editing/VisibleSelection.cpp » ('J')