ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.h - Issue 848833002: 1. Adds null check when keymap is failed to load. 2. Moves xkb_rule_names construction into worker …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.h

Issue 848833002: 1. Adds null check when keymap is failed to load. 2. Moves xkb_rule_names construction into worker … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.h

diff --git a/ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.h b/ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.h

index f92f113ed5b29ff228e97be58ad23e09b9c8f188..a6bf6f50cbd5b300aeae6863a72d1577fa491b73 100644

--- a/ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.h

+++ b/ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.h

@@ -41,10 +41,6 @@ class EVENTS_OZONE_LAYOUT_EXPORT XkbKeyboardLayoutEngine

KeyboardCode* key_code,

uint32* platform_keycode) const override;

- // Gets the names of the RMLO rule for libxkbcommon.

- // Makes it protected for testing.

- scoped_ptr<xkb_rule_names> GetXkbRuleNames(const std::string& layout_name);

protected:

// Table for EventFlagsToXkbFlags().

struct XkbFlagMapEntry {

« no previous file with comments | « no previous file | ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc » ('j') | ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc » ('J')