components/password_manager/content/common/credential_manager_types.h - Issue 848723002: Credential Manager API: Showing both local and federated logins.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/content/common/credential_manager_types.h

Issue 848723002: Credential Manager API: Showing both local and federated logins. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc ('k') | components/password_manager/content/common/credential_manager_types.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/content/common/credential_manager_types.h

diff --git a/components/password_manager/content/common/credential_manager_types.h b/components/password_manager/content/common/credential_manager_types.h

index 2a64acbc8ad1bc39f92b759deb89447b9592c1c3..324288bff4367df1188061798c0def8926c14a2f 100644

--- a/components/password_manager/content/common/credential_manager_types.h

+++ b/components/password_manager/content/common/credential_manager_types.h

@@ -26,6 +26,7 @@ namespace password_manager {

// something reasonably sane.

const size_t kMaxFederations = 50u;

+// TODO(melandory): Remove unsigned int.

enum class CredentialType : unsigned int {

CREDENTIAL_TYPE_EMPTY = 0,

CREDENTIAL_TYPE_LOCAL,

@@ -36,7 +37,8 @@ enum class CredentialType : unsigned int {

struct CredentialInfo {

CredentialInfo();

explicit CredentialInfo(const blink::WebCredential& credential);

- explicit CredentialInfo(const autofill::PasswordForm& form);

+ explicit CredentialInfo(const autofill::PasswordForm& form,

+ CredentialType form_type);

~CredentialInfo();

CredentialType type;