chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc - Issue 848723002: Credential Manager API: Showing both local and federated logins.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc

Issue 848723002: Credential Manager API: Showing both local and federated logins. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_ui_controller_mock.cc ('k') | chrome/browser/ui/views/passwords/credentials_item_view.h » ('j') | components/password_manager/content/common/credential_manager_types.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc

diff --git a/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc b/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc

index c12acc68759f5e375bc362705aa1c57a02db4646..ac6a73d65857cfdd48051d1051bd10cfa6b4328b 100644

--- a/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc

+++ b/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc

@@ -341,8 +341,8 @@ TEST_F(ManagePasswordsUIControllerTest, ChooseCredential) {

controller()->UpdateIconAndBubbleState(&mock);

EXPECT_EQ(password_manager::ui::CREDENTIAL_REQUEST_STATE, mock.state());

- controller()->ManagePasswordsUIController::ChooseCredential(true,

- test_form());

+ controller()->ManagePasswordsUIController::ChooseCredential(

+ test_form(), password_manager::CredentialType::CREDENTIAL_TYPE_LOCAL);

EXPECT_EQ(password_manager::ui::INACTIVE_STATE, controller()->state());

ASSERT_TRUE(credential_info());

EXPECT_EQ(test_form().username_value, credential_info()->id);

@@ -363,8 +363,8 @@ TEST_F(ManagePasswordsUIControllerTest, ChooseCredentialCancel) {

EXPECT_EQ(password_manager::ui::CREDENTIAL_REQUEST_AND_BUBBLE_STATE,

controller()->state());

- controller()->ManagePasswordsUIController::ChooseCredential(false,

- test_form());

+ controller()->ManagePasswordsUIController::ChooseCredential(

+ test_form(), password_manager::CredentialType::CREDENTIAL_TYPE_EMPTY);

EXPECT_EQ(password_manager::ui::INACTIVE_STATE, controller()->state());

ASSERT_TRUE(credential_info());

EXPECT_EQ(password_manager::CredentialType::CREDENTIAL_TYPE_EMPTY,