chrome/browser/ui/passwords/manage_passwords_ui_controller_mock.cc - Issue 848723002: Credential Manager API: Showing both local and federated logins.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/manage_passwords_ui_controller_mock.cc

Issue 848723002: Credential Manager API: Showing both local and federated logins. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review, please Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/passwords/manage_passwords_ui_controller.cc ('K') | « chrome/browser/ui/passwords/manage_passwords_ui_controller_mock.h ('k') | chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc » ('j') | chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/passwords/manage_passwords_ui_controller_mock.cc

diff --git a/chrome/browser/ui/passwords/manage_passwords_ui_controller_mock.cc b/chrome/browser/ui/passwords/manage_passwords_ui_controller_mock.cc

index 3d1b7de0d40b50611da008ac9bbd3071f2a300cf..5c62a52634df222e74457f4b097c1cfb92870fc6 100644

--- a/chrome/browser/ui/passwords/manage_passwords_ui_controller_mock.cc

+++ b/chrome/browser/ui/passwords/manage_passwords_ui_controller_mock.cc

@@ -4,6 +4,7 @@

#include "chrome/browser/ui/passwords/manage_passwords_ui_controller_mock.h"

+#include "components/password_manager/content/common/credential_manager_types.h"

#include "content/public/browser/web_contents.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -60,8 +61,8 @@ void ManagePasswordsUIControllerMock::NeverSavePasswordInternal() {

}

void ManagePasswordsUIControllerMock::ChooseCredential(

- bool was_chosen,

- const autofill::PasswordForm& form) {

+ const autofill::PasswordForm& form,

+ password_manager::CredentialType form_type) {

EXPECT_FALSE(choose_credential_);

choose_credential_ = true;

}