chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc - Issue 848723002: Credential Manager API: Showing both local and federated logins.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc

Issue 848723002: Credential Manager API: Showing both local and federated logins. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review, please Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_bubble_model.cc ('k') | chrome/browser/ui/passwords/manage_passwords_ui_controller.h » ('j') | chrome/browser/ui/passwords/manage_passwords_ui_controller.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc

diff --git a/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc b/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc

index debc5160a56d5452ef1b09baa922e7bb3de68708..ce77b7ff76a13a03a1867f0cfd4d5cef60b7dedd 100644

--- a/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc

+++ b/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc

@@ -10,6 +10,7 @@

#include "chrome/browser/ui/passwords/manage_passwords_bubble_model.h"

#include "chrome/browser/ui/passwords/manage_passwords_ui_controller_mock.h"

#include "chrome/test/base/testing_profile.h"

+#include "components/password_manager/content/common/credential_manager_types.h"

#include "components/password_manager/core/browser/password_manager_metrics_util.h"

#include "components/password_manager/core/browser/password_manager_url_collection_experiment.h"

#include "components/password_manager/core/common/password_manager_pref_names.h"

@@ -257,7 +258,8 @@ TEST_F(ManagePasswordsBubbleModelTest, ClickCredential) {

PretendCredentialsWaiting();

EXPECT_FALSE(controller()->choose_credential());

autofill::PasswordForm form;

- model_->OnChooseCredentials(form);

+ model_->OnChooseCredentials(

+ form, password_manager::CredentialType::CREDENTIAL_TYPE_LOCAL);

model_->OnBubbleHidden();

EXPECT_EQ(model_->dismissal_reason(),

password_manager::metrics_util::CLICKED_CREDENTIAL);