Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7339)

Unified Diff: chrome/browser/ui/passwords/manage_passwords_bubble_model.h

Issue 848723002: Credential Manager API: Showing both local and federated logins. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review, please Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/passwords/manage_passwords_bubble_model.h
diff --git a/chrome/browser/ui/passwords/manage_passwords_bubble_model.h b/chrome/browser/ui/passwords/manage_passwords_bubble_model.h
index 250dd89839c5d4cf474619c7bc5aee4cb90cfc45..d4e14c7f2ea2f4910f9f25883e1fabfe3e1e9b30 100644
--- a/chrome/browser/ui/passwords/manage_passwords_bubble_model.h
+++ b/chrome/browser/ui/passwords/manage_passwords_bubble_model.h
@@ -20,6 +20,10 @@ namespace content {
class WebContents;
}
+namespace password_manager {
+enum class CredentialType : unsigned int;
+}
+
// This model provides data for the ManagePasswordsBubble and controls the
// password management actions.
class ManagePasswordsBubbleModel : public content::WebContentsObserver {
@@ -81,7 +85,8 @@ class ManagePasswordsBubbleModel : public content::WebContentsObserver {
PasswordAction action);
// Called by the view code to notify about chosen credential.
- void OnChooseCredentials(const autofill::PasswordForm& password_form);
+ void OnChooseCredentials(const autofill::PasswordForm& password_form,
+ password_manager::CredentialType credential_type_);
GURL origin() const { return origin_; }
@@ -94,8 +99,13 @@ class ManagePasswordsBubbleModel : public content::WebContentsObserver {
const autofill::ConstPasswordFormMap& best_matches() const {
return best_matches_;
}
- const ScopedVector<autofill::PasswordForm>& pending_credentials() const {
- return pending_credentials_;
+ const ScopedVector<autofill::PasswordForm>& local_pending_credentials()
+ const {
+ return local_pending_credentials_;
+ }
+ const ScopedVector<autofill::PasswordForm>& federated_pending_credentials()
+ const {
+ return federated_pending_credentials_;
}
const base::string16& manage_link() const { return manage_link_; }
bool never_save_passwords() const { return never_save_passwords_; }
@@ -133,7 +143,8 @@ class ManagePasswordsBubbleModel : public content::WebContentsObserver {
base::string16 title_;
autofill::PasswordForm pending_password_;
autofill::ConstPasswordFormMap best_matches_;
- ScopedVector<autofill::PasswordForm> pending_credentials_;
+ ScopedVector<autofill::PasswordForm> local_pending_credentials_;
+ ScopedVector<autofill::PasswordForm> federated_pending_credentials_;
base::string16 manage_link_;
base::string16 save_confirmation_text_;
gfx::Range save_confirmation_link_range_;

Powered by Google App Engine
This is Rietveld 408576698