Credential Manager API: Showing both local and federated logins.

components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/password_manager/content/browser/credential_manager_dispatcher.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/run_loop.h"
 #include "base/strings/string16.h"
@@ skipping 37 matching lines @@
     did_prompt_user_to_save_ = true;
     manager_.reset(manager.release());
     return true;
   }
 
   bool PromptUserToChooseCredentials(
       const std::vector<autofill::PasswordForm*>& local_forms,
       const std::vector<autofill::PasswordForm*>& federated_forms,
       base::Callback<void(const password_manager::CredentialInfo&)> callback)
       override {
+    // TODO(melandory): Use ScopedVector instead of std::vector in arguments.
+    // ContentCredentialManagerDispatcher::OnGetPasswordStoreResults contains a
+    // memory leak because of this.
     EXPECT_FALSE(local_forms.empty() && federated_forms.empty());
     did_prompt_user_to_choose_ = true;
     ScopedVector<autofill::PasswordForm> local_entries;
     local_entries.assign(local_forms.begin(), local_forms.end());
     ScopedVector<autofill::PasswordForm> federated_entries;
     federated_entries.assign(federated_forms.begin(), federated_forms.end());
-    // TODO(vasilii): Do something clever with |federated_forms|.
-    password_manager::CredentialInfo info(*local_entries[0]);
+    password_manager::CredentialInfo info(
+        local_forms.empty() ? *federated_forms[0] : *local_entries[0],
+        local_forms.empty()
+            ? password_manager::CredentialType::CREDENTIAL_TYPE_FEDERATED
+            : password_manager::CredentialType::CREDENTIAL_TYPE_LOCAL);
     base::MessageLoop::current()->PostTask(FROM_HERE,
                                            base::Bind(callback, info));
     return true;
   }
 
   bool IsOffTheRecord() override { return is_off_the_record_; }
 
   bool did_prompt_user_to_save() const { return did_prompt_user_to_save_; }
   bool did_prompt_user_to_choose() const { return did_prompt_user_to_choose_; }
 
@@ skipping 105 matching lines @@
   dispatcher()->OnNotifyFailedSignIn(kRequestId, info);
 
   const uint32 kMsgID = CredentialManagerMsg_AcknowledgeFailedSignIn::ID;
   const IPC::Message* message =
       process()->sink().GetFirstMessageMatching(kMsgID);
   EXPECT_TRUE(message);
   process()->sink().ClearMessages();
 }
 
 TEST_F(CredentialManagerDispatcherTest, CredentialManagerOnNotifySignedIn) {
-  CredentialInfo info(form_);
+  CredentialInfo info(form_,
+                      password_manager::CredentialType::CREDENTIAL_TYPE_LOCAL);
   dispatcher()->OnNotifySignedIn(kRequestId, info);
 
   const uint32 kMsgID = CredentialManagerMsg_AcknowledgeSignedIn::ID;
   const IPC::Message* message =
       process()->sink().GetFirstMessageMatching(kMsgID);
   EXPECT_TRUE(message);
   process()->sink().ClearMessages();
 
   // Allow the PasswordFormManager to talk to the password store, determine
   // that the form is new, and set it as pending.
   RunAllPendingTasks();
 
   EXPECT_TRUE(client_->did_prompt_user_to_save());
   EXPECT_TRUE(client_->pending_manager()->HasCompletedMatching());
 
   autofill::PasswordForm new_form =
       client_->pending_manager()->pending_credentials();
   EXPECT_EQ(form_.username_value, new_form.username_value);
   EXPECT_EQ(form_.display_name, new_form.display_name);
   EXPECT_EQ(form_.password_value, new_form.password_value);
   EXPECT_EQ(form_.origin, new_form.origin);
   EXPECT_EQ(form_.signon_realm, new_form.signon_realm);
   EXPECT_EQ(autofill::PasswordForm::SCHEME_HTML, new_form.scheme);
 }
 
 TEST_F(CredentialManagerDispatcherTest, CredentialManagerIncognitoSignedIn) {
-  CredentialInfo info(form_);
+  CredentialInfo info(form_, CredentialType::CREDENTIAL_TYPE_LOCAL);
   client_->set_off_the_record(true);
   dispatcher()->OnNotifySignedIn(kRequestId, info);
 
   const uint32 kMsgID = CredentialManagerMsg_AcknowledgeSignedIn::ID;
   const IPC::Message* message =
       process()->sink().GetFirstMessageMatching(kMsgID);
   EXPECT_TRUE(message);
   process()->sink().ClearMessages();
 
   RunAllPendingTasks();
@@ skipping 114 matching lines @@
   const IPC::Message* message =
       process()->sink().GetFirstMessageMatching(kMsgID);
   ASSERT_TRUE(message);
   CredentialManagerMsg_SendCredential::Param param;
   CredentialManagerMsg_SendCredential::Read(message, &param);
   EXPECT_EQ(CredentialType::CREDENTIAL_TYPE_EMPTY, get<1>(param).type);
   EXPECT_FALSE(client_->did_prompt_user_to_choose());
 }
 
 }  // namespace password_manager