Issue 848713003: 1. Adds null check when keymap is failed to load. 2. Moves xkb_rule_names construction into worker …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 848713003: 1. Adds null check when keymap is failed to load. 2. Moves xkb_rule_names construction into worker … (Closed)

Created:
5 years, 11 months ago by Shu Chen

Modified:
5 years, 11 months ago

Reviewers:

CC:
chromium-reviews, kalyank, tdresser+watch_chromium.org, jdduke+watch_chromium.org, ozone-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2272

Target Ref:
refs/pending/branch-heads/2272

Project:
chromium

Visibility:
Public.

1. Adds null check when keymap is failed to load. 2. Moves xkb_rule_names construction into worker thread to fix crash problem. BUG=447415, 444121 Review URL: https://codereview.chromium.org/848833002 Cr-Commit-Position: refs/heads/master@{#311421} (cherry picked from commit a15f89531db60f3397c04adf1a5fdc08f0f058cc) Committed: https://chromium.googlesource.com/chromium/src/+/04ab5b21bc35508856fc7a7d395ac5344c7bfb91

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -43 lines)			Patch
M	ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc	View	4 chunks	+40 lines, -35 lines	0 comments	Download
M	ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine_unittest.cc	View	1 chunk	+6 lines, -4 lines	0 comments	Download

Total messages: 1 (0 generated)

Shu Chen

5 years, 11 months ago (2015-01-15 08:15:58 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
04ab5b21bc35508856fc7a7d395ac5344c7bfb91.