Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(941)

Unified Diff: runtime/vm/assembler_arm.cc

Issue 848703002: Improve constant pool implementation in the assembler. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/assembler_arm.cc
===================================================================
--- runtime/vm/assembler_arm.cc (revision 42873)
+++ runtime/vm/assembler_arm.cc (working copy)
@@ -3506,12 +3506,15 @@
ASSERT(Isolate::Current() != Dart::vm_isolate());
object_pool_ = GrowableObjectArray::New(Heap::kOld);
}
- for (intptr_t i = 0; i < object_pool_.Length(); i++) {
- if (object_pool_.At(i) == obj.raw()) {
- return i;
- }
+
+ intptr_t index = object_pool_index_table_.Lookup(&obj);
+ if (index != ObjIndexPair::kNoIndex) {
+ return index;
}
+
object_pool_.Add(obj, Heap::kOld);
+ object_pool_index_table_.Insert(
+ ObjIndexPair(&obj, object_pool_.Length() - 1));
return object_pool_.Length() - 1;
}

Powered by Google App Engine
This is Rietveld 408576698