Improve constant pool implementation in the assembler.

runtime/vm/assembler.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_ASSEMBLER_H_
 #define VM_ASSEMBLER_H_
 
 #include "platform/assert.h"
 #include "vm/allocation.h"
 #include "vm/globals.h"
@@ skipping 187 matching lines @@
   // description of kMinimumGap for the reasoning behind the value.
   static uword ComputeLimit(uword data, intptr_t capacity) {
     return data + capacity - kMinimumGap;
   }
 
   void ExtendCapacity();
 
   friend class AssemblerFixup;
 };
 
+
+// Pair type parameter for DirectChainedHashMap used for the constant pool.
+class ObjIndexPair {
+ public:
+  // Typedefs needed for the DirectChainedHashMap template.
+  typedef const Object* Key;
+  typedef intptr_t Value;
+  typedef ObjIndexPair Pair;
+
+  explicit ObjIndexPair(Value value) : key_(NULL), value_(NoValue()) { }

[Vyacheslav Egorov (Google), 2015/01/13 13:47:30]

I think parameter is redundant. Just provide default constructor.

[Florian Schneider, 2015/01/13 14:09:08]

Done.

+
+  ObjIndexPair(Key key, Value value)
+     : key_(key->IsNotTemporaryScopedHandle()
+         ? key : &Object::ZoneHandle(key->raw())),
+       value_(value) { }
+
+  static Key KeyOf(Pair kv) { return kv.key_; }
+
+  static Value ValueOf(Pair kv) { return kv.value_; }
+
+  static Value NoValue() { return -1; }
+
+  static intptr_t Hashcode(Key key) {
+    if (key->IsSmi()) {
+      return Smi::Cast(*key).Value();
+    }
+    if (key->IsDouble()) {
+      return static_cast<intptr_t>(
+          bit_cast<int32_t, float>(
+              static_cast<float>(Double::Cast(*key).value())));
+    }
+    if (key->IsMint()) {
+      return static_cast<intptr_t>(Mint::Cast(*key).value());
+    }
+    if (key->IsString()) {
+      return String::Cast(*key).Hash();
+    }
+    // TODO(fschneider): Add hash function for other classes commonly used as
+    // compile-time constants.
+    return key->GetClassId();
+  }
+
+  static inline bool IsKeyEqual(Pair kv, Key key) {
+    return kv.key_->raw() == key->raw();
+  }
+
+ private:
+  Key key_;
+  Value value_;
+};
+
 }  // namespace dart
 
 
 #if defined(TARGET_ARCH_IA32)
 #include "vm/assembler_ia32.h"
 #elif defined(TARGET_ARCH_X64)
 #include "vm/assembler_x64.h"
 #elif defined(TARGET_ARCH_ARM)
 #include "vm/assembler_arm.h"
 #elif defined(TARGET_ARCH_ARM64)
 #include "vm/assembler_arm64.h"
 #elif defined(TARGET_ARCH_MIPS)
 #include "vm/assembler_mips.h"
 #else
 #error Unknown architecture.
 #endif
 
 #endif  // VM_ASSEMBLER_H_