Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1443)

Unified Diff: Source/core/testing/Internals.h

Issue 848673002: Add keys(), values() and entries() methods on iterable<> interfaces (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/dom/Iterable.h ('k') | Source/core/testing/Internals.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/testing/Internals.h
diff --git a/Source/core/testing/Internals.h b/Source/core/testing/Internals.h
index 7a729e215e033859336dde567db28dafd70f5a4c..9e6f2e1495145596222168b5c8bfc5b2d122054b 100644
--- a/Source/core/testing/Internals.h
+++ b/Source/core/testing/Internals.h
@@ -33,6 +33,7 @@
#include "bindings/core/v8/ScriptWrappable.h"
#include "core/css/CSSComputedStyleDeclaration.h"
#include "core/dom/ContextLifecycleObserver.h"
+#include "core/dom/Iterable.h"
#include "core/page/scrolling/ScrollingCoordinator.h"
#include "platform/heap/Handle.h"
#include "wtf/PassRefPtr.h"
@@ -73,7 +74,7 @@ class UnionTypesTest;
template <typename NodeType> class StaticNodeTypeList;
typedef StaticNodeTypeList<Node> StaticNodeList;
-class Internals final : public GarbageCollectedFinalized<Internals>, public ScriptWrappable, public ContextLifecycleObserver {
+class Internals final : public GarbageCollectedFinalized<Internals>, public ScriptWrappable, public ContextLifecycleObserver, public ValueIterable<int> {
DEFINE_WRAPPERTYPEINFO();
WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(Internals);
public:
@@ -338,8 +339,6 @@ public:
void forcePluginPlaceholder(HTMLElement* plugin, PassRefPtrWillBeRawPtr<DocumentFragment>, ExceptionState&);
void forcePluginPlaceholder(HTMLElement* plugin, const PluginPlaceholderOptions&, ExceptionState&);
- Iterator* iterator(ScriptState*, ExceptionState&);
-
// Scheudle a forced Blink GC run (Oilpan) at the end of event loop.
// Note: This is designed to be only used from PerformanceTests/BlinkGC to explicitly measure only Blink GC time.
// Normal LayoutTests should use gc() instead as it would trigger both Blink GC and V8 GC.
@@ -354,6 +353,8 @@ private:
DocumentMarker* markerAt(Node*, const String& markerType, unsigned index, ExceptionState&);
Member<InternalRuntimeFlags> m_runtimeFlags;
+
+ IterationSource* startIteration(ScriptState*, ExceptionState&) override;
};
} // namespace blink
« no previous file with comments | « Source/core/dom/Iterable.h ('k') | Source/core/testing/Internals.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698