Add keys(), values() and entries() methods on iterable<> interfaces

Source/core/testing/Internals.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  * Copyright (C) 2013 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 138 matching lines @@
 #include "wtf/InstanceCounter.h"
 #include "wtf/PassOwnPtr.h"
 #include "wtf/dtoa.h"
 #include "wtf/text/StringBuffer.h"
 #include <v8.h>
 
 namespace blink {
 
 namespace {
 
-class InternalsIterator final : public Iterator {
+class InternalsIterationSource final : public ValueIterable<int>::IterationSource {
 public:
-    InternalsIterator() : m_current(0) { }
-
-    virtual ScriptValue next(ScriptState* scriptState, ExceptionState& exceptionState) override
+    virtual bool next(ScriptState* scriptState, int& value, ExceptionState& exceptionState) override

[yhirano, 2015/01/13 05:18:42]

No virtual is needed.

[Jens Widell, 2015/01/13 07:50:06]

Done.

     {
-        int value = m_current * m_current;
-        if (m_current >= 5)
-            return v8IteratorResultDone(scriptState);
-        ++m_current;
-        return v8IteratorResult(scriptState, value);
+        if (m_index >= 5)
+            return false;
+        value = m_index * m_index;
+        return true;
     }
-
-    virtual ScriptValue next(ScriptState* scriptState, ScriptValue value, ExceptionState& exceptionState) override
-    {
-        exceptionState.throwTypeError("Not implemented");
-        return ScriptValue();
-    }
-
-private:
-    int m_current;
 };
 
 } // namespace
 
 static bool markerTypesFrom(const String& markerType, DocumentMarker::MarkerTypes& result)
 {
     if (markerType.isEmpty() || equalIgnoringCase(markerType, "all"))
         result = DocumentMarker::AllMarkers();
     else if (equalIgnoringCase(markerType, "Spelling"))
         result =  DocumentMarker::Spelling;
@@ skipping 2167 matching lines @@
 
 void Internals::forcePluginPlaceholder(HTMLElement* element, const PluginPlaceholderOptions& options, ExceptionState& exceptionState)
 {
     if (!element->isPluginElement()) {
         exceptionState.throwDOMException(InvalidNodeTypeError, "The element provided is not a plugin.");
         return;
     }
     toHTMLPlugInElement(element)->setPlaceholder(DictionaryPluginPlaceholder::create(element->document(), options));
 }
 
-Iterator* Internals::iterator(ScriptState* scriptState, ExceptionState& exceptionState)
-{
-    return new InternalsIterator;
-}
-
 void Internals::forceBlinkGCWithoutV8GC()
 {
     ThreadState::current()->scheduleGC();
 }
 
+ValueIterable<int>::IterationSource* Internals::startIteration(ScriptState*, ExceptionState&)
+{
+    return new InternalsIterationSource();
+}
+
 } // namespace blink