Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: content/browser/accessibility/browser_accessibility.h

Issue 848653002: Re-land: Send Windows accessibility events based on tree updates. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@implicit_1_tests
Patch Set: Remove logging Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/browser_accessibility.h
diff --git a/content/browser/accessibility/browser_accessibility.h b/content/browser/accessibility/browser_accessibility.h
index e399b8604f59bc6ffd97bb004b2d65ea0e85fdd4..cb47019a8868098643c1db5ae0e025bc84bb55de 100644
--- a/content/browser/accessibility/browser_accessibility.h
+++ b/content/browser/accessibility/browser_accessibility.h
@@ -56,12 +56,16 @@ class CONTENT_EXPORT BrowserAccessibility {
// Called after the object is first initialized and again every time
// its data changes.
- virtual void OnDataChanged();
+ virtual void OnDataChanged() {}
// Called after an atomic update to the tree finished and this object
// was created or changed in this update.
virtual void OnUpdateFinished() {}
+ virtual void OnSubtreeWillBeDeleted() {}
+
+ virtual void OnSubtreeCreationFinished() {}
+
// Returns true if this is a native platform-specific object, vs a
// cross-platform generic object.
virtual bool IsNative() const;
@@ -88,6 +92,11 @@ class CONTENT_EXPORT BrowserAccessibility {
// invalid index. Returns NULL if PlatformIsLeaf() returns true.
BrowserAccessibility* PlatformGetChild(uint32 child_index) const;
+ // Returns true if an ancestor of this node (not including itself) is a
+ // leaf node, meaning that this node is not actually exposed to the
+ // platform.
+ bool PlatformIsChildOfLeaf() const;
+
// Return the previous sibling of this object, or NULL if it's the first
// child of its parent.
BrowserAccessibility* GetPreviousSibling();
@@ -140,10 +149,6 @@ class CONTENT_EXPORT BrowserAccessibility {
BrowserAccessibilityManager* manager() const { return manager_; }
bool instance_active() const { return node_ != NULL; }
ui::AXNode* node() const { return node_; }
- const std::string& name() const { return name_; }
- const std::string& value() const { return value_; }
- void set_name(const std::string& name) { name_ = name; }
- void set_value(const std::string& value) { value_ = value; }
// These access the internal accessibility tree, which doesn't necessarily
// reflect the accessibility tree that should be exposed on each platform.
@@ -214,9 +219,6 @@ class CONTENT_EXPORT BrowserAccessibility {
bool GetIntListAttribute(ui::AXIntListAttribute attribute,
std::vector<int32>* value) const;
- void SetStringAttribute(ui::AXStringAttribute attribute,
- const std::string& value);
-
// Retrieve the value of a html attribute from the attribute map and
// returns true if found.
bool GetHtmlAttribute(const char* attr, base::string16* value) const;
@@ -250,9 +252,6 @@ class CONTENT_EXPORT BrowserAccessibility {
// True if this is a web area, and its grandparent is a presentational iframe.
bool IsWebAreaForPresentationalIframe() const;
- // Append the text from this node and its children.
- std::string GetTextRecursive() const;
-
protected:
BrowserAccessibility();
@@ -267,9 +266,6 @@ class CONTENT_EXPORT BrowserAccessibility {
// including this object if it's static text.
int GetStaticTextLenRecursive() const;
- std::string name_;
- std::string value_;
-
DISALLOW_COPY_AND_ASSIGN(BrowserAccessibility);
};

Powered by Google App Engine
This is Rietveld 408576698